Allow required install scripts - #179
Merged
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
api | 2a41f79 | Commit Preview URL Branch Preview URL |
Aug 03 2026, 05:45 AM |
Contributor
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="package.json">
<violation number="1" location="package.json:60">
P2: This new `allowScripts` block is inert as committed: npm doesn't read a top-level `allowScripts` field — it's consumed by the `@lavamoat/allow-scripts` tool (which also needs `ignore-scripts=true` in `.npmrc` to actually block/enable scripts). Neither that devDependency, nor a `.npmrc`, nor any workflow that runs `allow-scripts` exists in this repo, and per the LavaMoat docs the config is expected nested under `lavamoat.allowScripts` rather than top-level. As it stands the field has no effect, so required install scripts (esbuild binary download, workerd, fsevents) will not actually be allowed. Consider either wiring up the tooling and placing the config where it's read (e.g. `"lavamoat": { "allowScripts": { ... } }`), or dropping the dead config until the enabling setup lands. Note also that pinning exact versions of these transitive deps (esbuild/workerd/fsevents) means any future dependency bump will silently leave the new version's script disallowed.</violation>
</file>
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Allow required install scripts via the new
allowScriptsfield to unblock CI/local installs, adding entries foresbuild@0.18.20,esbuild@0.25.12,esbuild@0.28.1,fsevents@2.3.3, andworkerd@1.20260730.1. Also refreshes the lockfile with minor/patch bumps, includingvite@8.2.0androlldown@1.2.1.Written for commit 2a41f79. Summary will update on new commits.