bgpd: improve/clarify bgp static tables#19640
Merged
ton31337 merged 2 commits intoFRRouting:masterfrom Oct 8, 2025
Merged
Conversation
ton31337
approved these changes
Sep 29, 2025
Contributor
Author
|
CI:rerun |
Member
|
@Mergifyio rebase |
✅ Branch has been successfully rebased |
ton31337
force-pushed
the
fix_bgp_static
branch
from
64ba33c to
112d2c0
Compare
Member
|
@Mergifyio rebase |
added 2 commits
October 2, 2025 12:03
Don't use the route "get" api when removing statics: that will allocate new objects. Just do a lookup and return if the target isn't present. Signed-off-by: Mark Stapp <mjs@cisco.com>
Rename the tables of internal/static routes to be more clear about their function. Signed-off-by: Mark Stapp <mjs@cisco.com>
✅ Branch has been successfully rebased |
ton31337
force-pushed
the
fix_bgp_static
branch
from
112d2c0 to
7df5628
Compare
Member
|
LGTM will go in once release freeze is over |
cscarpitta
added a commit
to cscarpitta/sonic-buildimage
that referenced
this pull request
Mar 3, 2026
Port the following patches from FRR mainline to support BGP SRv6 GRT: - explicit SRv6 address configurable per address family (FRRouting/frr#19088) - bgpd: add output support for srv6 l3vpn attribute option (FRRouting/frr#19117) - BGP SRv6 locator per vrf (FRRouting/frr#19100) - bgpd: various fixes related to VPN SRv6 entries updates (FRRouting/frr#19447) - SRv6/MPLS L3 Services Co-existence (FRRouting/frr#19164) - bgpd: Fix incorrect flag checks for SRv6 SID allocation (FRRouting/frr#19623) - SRv6/MPLS Coexistence in L3VPN / formatting fixes (FRRouting/frr#19639) - Route-map command to filter out VPN paths based on their origin (MPLS /SRv6 / VXLAN) (FRRouting/frr#19717) - bgpd: improve/clarify bgp static tables (FRRouting/frr#19640) - bgpd: add SRv6 unicast at default VRF (FRRouting/frr#19496) Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
cscarpitta
added a commit
to cscarpitta/sonic-buildimage
that referenced
this pull request
Mar 4, 2026
Port the following patches from FRR mainline to support BGP SRv6 GRT: - explicit SRv6 address configurable per address family (FRRouting/frr#19088) - bgpd: add output support for srv6 l3vpn attribute option (FRRouting/frr#19117) - BGP SRv6 locator per vrf (FRRouting/frr#19100) - bgpd: various fixes related to VPN SRv6 entries updates (FRRouting/frr#19447) - SRv6/MPLS L3 Services Co-existence (FRRouting/frr#19164) - bgpd: Fix incorrect flag checks for SRv6 SID allocation (FRRouting/frr#19623) - SRv6/MPLS Coexistence in L3VPN / formatting fixes (FRRouting/frr#19639) - Route-map command to filter out VPN paths based on their origin (MPLS /SRv6 / VXLAN) (FRRouting/frr#19717) - bgpd: improve/clarify bgp static tables (FRRouting/frr#19640) - bgpd: add SRv6 unicast at default VRF (FRRouting/frr#19496) Signed-off-by: Carmine Scarpitta <cscarpit@cisco.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename the tables of internal/static routes to "static_routes", to make their function more clear. When deleting a static, use a "lookup" api instead of a "get" api - the "get" form can allocate objects, which we don't intend to do when withdrawing.