bgpd: output 'graceful-restart' value for peer group in 'write' command#20338
Merged
riw777 merged 2 commits intoFRRouting:masterfrom Jan 6, 2026
Merged
bgpd: output 'graceful-restart' value for peer group in 'write' command#20338riw777 merged 2 commits intoFRRouting:masterfrom
riw777 merged 2 commits intoFRRouting:masterfrom
Conversation
riw777
reviewed
Dec 30, 2025
Member
riw777
left a comment
riw777
left a comment
There was a problem hiding this comment.
looks good ... waiting on comment/discussion about why this was changed in the first place to make certain this is correct
ton31337
reviewed
Jan 4, 2026
| neighbor 192.168.34.4 timers 1 3 | ||
| neighbor 192.168.34.4 timers connect 1 | ||
| neighbor 192.168.34.4 graceful-restart | ||
| neighbor PG peer-group |
Member
There was a problem hiding this comment.
Can we leave the 192.168.34.4 peer as it was before? And add a peer-group additionally (separate topotest is fine too).
Contributor
Author
There was a problem hiding this comment.
Of course.
Changed test so that original test is untouched except adding peer-group + starting back r3 at the end of test.
Added new test method that checks only this issue.
hedrok
force-pushed
the
fix-bgp-gr-per-neighbor-output
branch
from
2b1622a to
c64cb20
Compare
Check that for peer groups value of graceful-restart is written by `write` command. Signed-off-by: Kyrylo Yatsenko <hedrok@gmail.com>
…ups" This reverts commit d34b973. Signed-off-by: Kyrylo Yatsenko <hedrok@gmail.com>
hedrok
force-pushed
the
fix-bgp-gr-per-neighbor-output
branch
from
c64cb20 to
a8bf21b
Compare
Contributor
Author
|
ci:rerun |
Contributor
Member
|
@Mergifyio backport stable/10.5 stable/10.4 stable/10.3 stable/10.2 |
✅ Backports have been createdDetails
|
This was referenced Jan 22, 2026
Merged
Closed
Closed
donaldsharp
added a commit
that referenced
this pull request
Jan 22, 2026
bgpd: output 'graceful-restart' value for peer group in 'write' command (backport #20338)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revert of d34b973 (merged in #18305)
The reverted commit prevented output of
graceful-restartvalue for peer groups.Setting option
graceful-restartfor peer group is allowed, it is used by peers that are in this group. I've modified test to demonstrate this and to catch regressions.Dear @Pdoijode @vivek-cumulus I'm sure you had reasons to add this commit, but description contains only
Could you please describe which problem it tried to solve?..