Skip to content

bgpd: Use the default local-preference value and not 0 when adjusting#20400

Merged
donaldsharp merged 2 commits intoFRRouting:masterfrom
opensourcerouting:fix/local_pref_add_substract
Jan 8, 2026
Merged

bgpd: Use the default local-preference value and not 0 when adjusting#20400
donaldsharp merged 2 commits intoFRRouting:masterfrom
opensourcerouting:fix/local_pref_add_substract

Conversation

@ton31337
Copy link
Member

@ton31337 ton31337 commented Jan 8, 2026

Closes #20366

If we use something like:

route-map x permit 10
 set local-preference +10

We treat that a default is 0, but it's not. We MUST respect the default
BGP local preference value that is set.

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
…sting one

Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
@frrbot frrbot bot added bgp tests Topotests, make check, etc labels Jan 8, 2026
@ton31337
Copy link
Member Author

ton31337 commented Jan 8, 2026

@Mergifyio backport stable/10.5 stable/10.4 stable/10.3

@mergify
Copy link

mergify bot commented Jan 8, 2026

backport stable/10.5 stable/10.4 stable/10.3

✅ Backports have been created

Details

@donaldsharp donaldsharp merged commit 738ad28 into FRRouting:master Jan 8, 2026
23 checks passed
@ton31337 ton31337 deleted the fix/local_pref_add_substract branch January 8, 2026 13:45
donaldsharp added a commit that referenced this pull request Jan 8, 2026
bgpd: Use the default local-preference value and not 0 when adjusting (backport #20400)
donaldsharp added a commit that referenced this pull request Jan 8, 2026
bgpd: Use the default local-preference value and not 0 when adjusting (backport #20400)
donaldsharp added a commit that referenced this pull request Jan 8, 2026
bgpd: Use the default local-preference value and not 0 when adjusting (backport #20400)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BGPD: LOCAL_PREF attribute not updated properly when +x or -x used in route-map applied on external routes

2 participants