Send register in fhr lhr case#20575
Merged
Jafaral merged 2 commits intoFRRouting:masterfrom Jan 23, 2026
Merged
Conversation
Member
|
minor frrbot style suggestion |
Member
|
Is there any topotest we can update to capture this case? |
Member
Author
|
The PR from @gromit1811 shows that this is fixed, but it needs both updating in several ways that I was not interested in tracking down/fixing, as that it lead down other rabbit holes. this problem is fixed though. |
Member
|
@Mergifyio backport stable/10.5 stable/10.4 |
✅ Backports have been createdDetails
|
This function was modified to allow you to use v4/v6 but the last step to allow this to work under v6 was never taken. Let's rectify that. Signed-off-by: Donald Sharp <sharpd@nvidia.com>
When a FHR is also a LHR, and the S,G upstream is created before any multicast packets for the S,G have flown, we need to be able to let the pim state machine handle the registration towards the RP. Modify the code to notice that packets are flowing on the S,G stream and that we are a LHR. This will allow us to send register messages when this happens, to allow other parts of the *,G tree participate if needed. Fixes: FRRouting#18445 Signed-off-by: Donald Sharp <sharpd@nvidia.com>
donaldsharp
force-pushed
the
send_register_in_fhr_lhr_case
branch
from
5e57441 to
f41e730
Compare
This was referenced Jan 23, 2026
donaldsharp
added a commit
that referenced
this pull request
Jan 23, 2026
Send register in fhr lhr case (backport #20575)
donaldsharp
added a commit
that referenced
this pull request
Jan 23, 2026
Send register in fhr lhr case (backport #20575)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if pim is both a FHR and a LHR for a S,G, it is possible that the actions of the LHR or other actions on the network can cause a S,G join to happen on the LHR prior to any S, G stream flowing. When this happens pimd was not correctly transitioning the S,G mroute to have a pimreg device to allow for proper registration of the S,G with the RP. This fixes this problem.
Fixes #18445