ci: Adjust github workflows (actions)#21353
Conversation
That causes frrbot to require an approval for running these actions. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Not used anymore. Signed-off-by: Donatas Abraitis <donatas@opensourcerouting.org>
Greptile SummaryThis PR adjusts three GitHub Actions workflows: it removes
Confidence Score: 2/5
Important Files Changed
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant GH as GitHub
participant FreezeWF as freeze.yml workflow
Note over Dev,FreezeWF: ✅ Covered: label present at last synchronize
Dev->>GH: Push new commit (synchronize)
GH->>FreezeWF: Trigger (synchronize)
FreezeWF-->>GH: fail — "freeze" label detected
Note over Dev,FreezeWF: ❌ Gap introduced by this PR: label added after last sync
Dev->>GH: Push new commit (synchronize, no freeze label)
GH->>FreezeWF: Trigger (synchronize)
FreezeWF-->>GH: pass — no freeze label
Note over Dev,GH: Time passes…
Dev->>GH: Maintainer adds "freeze" label
Note over GH,FreezeWF: labeled event removed → workflow NOT triggered
GH-->>Dev: Branch protection shows ✅ (stale pass)
Dev->>GH: PR can be merged despite freeze label
Prompt To Fix All With AIThis is a comment left during a code review.
Path: .github/workflows/freeze.yml
Line: 5
Comment:
**Freeze label no longer re-triggers the check**
Removing `labeled` and `unlabeled` from the trigger list breaks the primary enforcement scenario for this workflow: a maintainer applies a "freeze" or "do not merge" label to a PR that hasn't had any new commits pushed since it last passed the `freeze_warning` check.
Without the `labeled` trigger, the workflow won't re-run when the label is added. The old **passing** status from the previous `synchronize` run remains on GitHub's check suite for that commit SHA. If `freeze_warning` is a required status check in branch protection rules, that stale green result is sufficient for GitHub to allow the merge — even though the PR now carries a "freeze" label.
The `behind-base.yml` change (also removing `labeled`/`unlabeled`) is much lower risk because that workflow only _adds_ a label and is not used as a blocking gate. But for `freeze.yml`, the `labeled` event is load-bearing: it is the only trigger that fires when a maintainer applies the freeze label to an already-open, already-passing PR.
```suggestion
types: [synchronize, opened, reopened, labeled, unlabeled]
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "ci: Drop commitling Github actions" | Re-trigger Greptile |
| on: | ||
| pull_request_target: | ||
| types: [synchronize, opened, reopened, labeled, unlabeled] | ||
| types: [synchronize, opened, reopened] |
There was a problem hiding this comment.
Freeze label no longer re-triggers the check
Removing labeled and unlabeled from the trigger list breaks the primary enforcement scenario for this workflow: a maintainer applies a "freeze" or "do not merge" label to a PR that hasn't had any new commits pushed since it last passed the freeze_warning check.
Without the labeled trigger, the workflow won't re-run when the label is added. The old passing status from the previous synchronize run remains on GitHub's check suite for that commit SHA. If freeze_warning is a required status check in branch protection rules, that stale green result is sufficient for GitHub to allow the merge — even though the PR now carries a "freeze" label.
The behind-base.yml change (also removing labeled/unlabeled) is much lower risk because that workflow only adds a label and is not used as a blocking gate. But for freeze.yml, the labeled event is load-bearing: it is the only trigger that fires when a maintainer applies the freeze label to an already-open, already-passing PR.
| types: [synchronize, opened, reopened] | |
| types: [synchronize, opened, reopened, labeled, unlabeled] |
Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/freeze.yml
Line: 5
Comment:
**Freeze label no longer re-triggers the check**
Removing `labeled` and `unlabeled` from the trigger list breaks the primary enforcement scenario for this workflow: a maintainer applies a "freeze" or "do not merge" label to a PR that hasn't had any new commits pushed since it last passed the `freeze_warning` check.
Without the `labeled` trigger, the workflow won't re-run when the label is added. The old **passing** status from the previous `synchronize` run remains on GitHub's check suite for that commit SHA. If `freeze_warning` is a required status check in branch protection rules, that stale green result is sufficient for GitHub to allow the merge — even though the PR now carries a "freeze" label.
The `behind-base.yml` change (also removing `labeled`/`unlabeled`) is much lower risk because that workflow only _adds_ a label and is not used as a blocking gate. But for `freeze.yml`, the `labeled` event is load-bearing: it is the only trigger that fires when a maintainer applies the freeze label to an already-open, already-passing PR.
```suggestion
types: [synchronize, opened, reopened, labeled, unlabeled]
```
How can I resolve this? If you propose a fix, please make it concise.There was a problem hiding this comment.
This is intentional. We don't need to trigger these actions when frrbot labels/unlabels.
No description provided.