pimd: fix dense mode State Refresh relay forwarding (backport #22177)#22203
Merged
Conversation
Author
Jafar: fixed. |
|
Target branch is not in the allowed branches list. |
33fa100 to
f04d517
Compare
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
The State Refresh relay path had two bugs that prevented multi-hop propagation in dense-mode. 1. pim_staterefresh_recv() forwarded on the receiving interface's neighbor list (pim_ifp->pim_neighbor_list), so the message was echoed back onto the segment it arrived on instead of being forwarded downstream. RFC 3973 4.5.2 requires State Refresh to be sent on every downstream PIM dense-mode interface, i.e. all PIM interfaces except the incoming one. Iterate FOR_ALL_INTERFACES and skip the receiving interface, matching pim_send_staterefresh(). 2. Both the receive (relay) and originate paths gated forwarding on neigh->prefix_list being non-NULL. That field is the neighbor's secondary-address list from Hello and is unrelated to State Refresh forwarding; in a normal deployment no router advertises one, so the loop body never executed and State Refresh was never relayed or originated. Remove the guard from both paths. Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com> (cherry picked from commit b459d0f)
Signed-off-by: Jafar Al-Gharaibeh <jafar@atcorp.com> (cherry picked from commit bbe9c59)
f04d517 to
f9bc8b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The State Refresh relay path had two bugs that prevented multi-hop
propagation in dense-mode.
This is an automatic backport of pull request #22177 done by Mergify.