[Bug]: Background image alignement with quest shifting around

[5ully]

Mod

FTB Quests

Mod version

2101.1.5

NeoForge / Forge / Fabric version

Neoforge 21.1.115

Modpack & version

FTB Oceanblock 1.0.0

What issue are you having?

Backround images shifts unlike quests when zooming. See image in notes for details

Crashlogs

n/a

Steps to reproduce

Open up the quest book, find a image like first image on the intro page for Oceanblock 2 and zoom back and forth while observing the alignement of the quest vs the background image.

Anything else to note?

Ill add a image series of the image/quest on how they render for me.
Max zoom:

One zoom out:

Two Zoom out:

Three zoom out:

Four Zoom Out:

Five zoom out:

And Max zoom out

This might be a similar issue to #1160 but who knows, another good example quest is the sifter quest with a light blue background or the nether quest.

This might also just be a pack issue (hard to tell from my view), but we all know Saereth won't be happy If I report quest book issues on the pack tracker.

[desht]

Confirmed, can reproduce.

Not sure yet, but I think this a fairly fundamental issue at the FTB Library level, which uses integer math for positioning and sizing widgets. Doing a little debugging on the scaling calculations does suggest some rounding errors are happening.

This could be fixed by changing everything in FTB Library to use floating-point positioning, but it's going to take a bit of work, not least to ensure backwards compatibility. Alternatively a bit more intelligent rounding in FTB Quests' calculations might work in the short term. Checking that now...

Update: better rounding in FTB Quests helps this problem, and possibly partially helps the problems reported in #1160, but isn't a complete solution. Still, it's a step in the right direction. Long term fix is a more fundamental rework of FTB Library widget positioning and sizing arithmetic...

[5ully]

Great work! Thanks for the amazing work you do!