[Bug]: Quests not being registered as completed

[FeelingOwl]

Mod

FTB Quests

Mod version

ftb-quests-forge-2001.4.10

NeoForge / Forge / Fabric version

1.20.1 Forge - 47.3.27

Modpack & version

Craft to Exile 2 (so far all versions)

What issue are you having?

As somehow being involved with the dev of pack, we encounter strange bug where some of the quests with various tasks do not register as being completed. Mostly affected quest tasks are involving mob kills, but item tasks/finding biome or structure tasks sometimes bug out too. We were encountering this issue throughout whole list of versions from 0.1.0 to latest 0.9.2.
Each update we get bug reports asking about broken quests. Some of them being reported in our issue tracker in discord (https://discord.com/channels/726729169999888495/1114788530657443881) but mostly just in general chat.
So far we couldnt pinpoint anything specific that might mess with FTB Quests.

Crashlogs

No response

Steps to reproduce

Seems that issue occurs randomly throughout gameplay without any common reason.

Anything else to note?

No response

[desht]

This is unfortunately too vague a problem description to have any chance of tracking down. I have not encountered any similar problems either in dev or when playing, so I would need a specific case to be able to reproduce the problem before being able to debug.

[RetroRyIn]

Mod
FTB Quests

Mod version
ftb-quests-neoforge-2101.1.6

NeoForge / Forge / Fabric version
1.21.1 Neoforge - 21.1.131

Modpack & version
ATM10

What issue are you having?
Having the exact same issue as above, quests will be marked with blue outline and a checkmark as if they are completed and requirements show as 100% but the requirements are not shown as completed in the quest book and the reward cannot be claimed and progress cannot be continued if subsequent quests are locked via dependencies. The ATM discord had to make a command addressing this issue with a bot response. I am playing on a private server and I'm not the only one on it this has happened to and having to ask for OP is not something viable for multiplayer if you're not already the host.

Crashlogs
N/A

Steps to reproduce
Happens via normal gameplay, Possibly if completing too many quests simultaneously or too quickly.

Anything else to note?
Images

[desht]

Once again:

I would need a specific case to be able to reproduce the problem before being able to debug.

[CynSolveroftheAbsolute]

It's to do with flexible task completion and the quest checking the item of the prior quest, not the quest itself. Flexible task completion on its own works just fine, but if you have a quest checking the dependency of another quest with it on, it bugs out and does this.

You can actually do what is visually the same thing by giving a quest two check marks, clicking one and deleting the one you didn't click. From what I've observed, it's only check if a quest should be completed when a requirement of the quest is completed, not whenever the quest itself is updated, making quests perma wait on conditions that no longer exist.

If this new info finally allows you to fix this, I am begging you to backport to 1.20, no idea the chance but if you're willing to I would be so happy to finally have this issue gone, or let me know what you changed somehow and I'll learn Java to fix this for 1.20. I want this fixed so badly
Tested with architectury-13.0.8-neoforge, ftb-library-neoforge-2101.1.30, ftb-quests-neoforge-2101.1.30, ftb-teams-neoforge-2101.1.9, and jei-1.21.1-neoforge-19.27.0.336 activated, Neoforge version 21.1.219, and obviously Minecraft 1.21.1

[CynSolveroftheAbsolute]

Little more finicky to reproduce on 1.20, I think that might be tied to cross-chapter quest conditions specifically rather than the more general "awaiting condition that doesn't exist" thing that 1.21 seems to be doing

[desht]

If I can track it down on 1.21.1, I'll definitely do a 1.20.1 backport. The info you've added could be helpful, thanks.