Feature/develop - #23
Merged
Merged
Conversation
- Remove DefaultWeight field from DimensionConfig struct - Update GetWeight() to return 0.0 for unset match types instead of DefaultWeight - Update CalculateTotalWeight() to use 0.0 for missing dimension weights - Update constructor signatures: - NewDimensionConfig(name, index, required) - NewDimensionConfigWithWeights(name, index, required, weights) - Fix all test expectations to use 0.0 default weights - Update all example code and cmd utilities - Add explicit weights to TestRebuild to avoid weight conflicts - Maintain 71.4% test coverage with all weight functionality working Breaking Change: DimensionConfig no longer has DefaultWeight field. Use SetWeight() method to set explicit weights for match types.
cloorc
force-pushed
the
feature/develop
branch
from
September 5, 2025 00:29
65f9efb to
15f8a36
Compare
cloorc
approved these changes
Sep 5, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.