Update from original #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactoring of hooks - angleOffset, angleArc (fix #36) - canvas pre-rendering - (lot of) optimizations - 5+ digit support - improved positioning of the input - Knob is now part of Kontrol ^^ - tron skin removed - ticks removed
Add ability to set input color & line cap style @jaketrent
Added feature detection to prevent the plugin from executing if the browser doesn't support canvases. Added the `error` hook, triggered if the browser doesn't support canvases.
Prevent errors in browsers that don't support canvases
Reading the plugin code I noticed that cursor width could be changed passing a numeric value, so I changed the readme in order to explain this useful feature.
"cursor" option explained better in readme file
added excanvas support code from @buradleix https://github.com/buradleix/jQuery-Knob/
excanvas support for IE7/8 compatibility
In order to require this plugin using Require JS or another AMD system both this plugin and JQuery itself must be AMD-compatible. This PR adds the Universal Module Defintion pattern from https://github.com/umdjs/umd so it works as expected with AMD and with traditional methods of inclusion.
The previous jQuery version dependency tied the plugin to version 1.7, not 1.7.1 or higher. I'm assuming this is compatible with 2.X too, so loosened it to >=1.7. If it's not 2.X compatible, you could tighten it to ~1.7 for all 1.X releases after 1.7
Add UMD declaration
loosen jquery version dependency
Fix #160, data-bgColor = "none" support
Syntax highlighting on README.md
Added a CommonJS module declaration
Owner
Author
|
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.