chore(retentions): add new retentions method for support drafts - #282
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the v2 OpenAPI specs (Spanish + English) to support “draft” retentions, including creating retentions as drafts, editing drafts, copying an existing retention into a draft, and stamping a draft when ready.
Changes:
- Document draft creation behavior (
status: "draft") and addis_ready_to_stampto theRetentionschema. - Add new endpoints for draft workflows: update draft (
PUT /retentions/{retention_id}), copy to draft, and stamp draft. - Add
statusfiltering to the retentions list endpoint and adjust cancellation docs/params for draft vs non-draft retentions.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| website/openapi_v2.yaml | Spanish OpenAPI updates for draft retentions, new endpoints, status filtering, and schema changes. |
| website/openapi_v2.en.yaml | English OpenAPI updates mirroring the Spanish draft retention additions and schema/endpoint changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
raul-facturapi
force-pushed
the
chore/retention_drafts
branch
from
August 3, 2026 19:55
fe41df5 to
3528c8f
Compare
edgtz
approved these changes
Aug 3, 2026
raul-facturapi
force-pushed
the
chore/retention_drafts
branch
from
August 3, 2026 21:39
3528c8f to
071c05b
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (1)
website/openapi_v2.yaml:6533
- Typo in Spanish description: "comúnes" should be "comunes" (no accent).
A diferencia de las facturas comúnes, la cancelación de la retención es inmediata y no requiere autorización de parte del receptor.
javorosas
reviewed
Aug 3, 2026
| type: array | ||
| items: | ||
| type: string | ||
| enum: |
| - in: query | ||
| name: motive | ||
| required: true | ||
| required: false |
Member
There was a problem hiding this comment.
El motivo no es requerido? Si no, hay que poner cual es el default
Collaborator
Author
There was a problem hiding this comment.
Listo, corregido a true
raul-facturapi
force-pushed
the
chore/retention_drafts
branch
from
August 4, 2026 03:32
071c05b to
81cfe18
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.