Fix publish package script and the package manifest - #2
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the publish workflow to source package versions directly from package.json rather than using npm version --json and jq.
- Replace
npm version --json | jq -r ...calls withnode -p "require('./package.json').version"for both current and new version retrieval.
Comments suppressed due to low confidence (1)
.github/workflows/publish.yml:57
- This change reads the same version twice without actually incrementing it, so NEW_VERSION will match CURRENT_VERSION and the git tag won’t advance. Consider adding a version bump step (e.g.,
npm version patch --no-git-tag-version) before reading the new version.
NEW_VERSION=$(node -p "require('./package.json').version")
HardlyDifficult
force-pushed
the
fixPublishPackage
branch
from
July 8, 2025 17:50
dadf6ec to
b0cbb0d
Compare
HardlyDifficult
changed the title
HardlyDifficult
added a commit
that referenced
this pull request
Jul 8, 2025
HardlyDifficult
added a commit
that referenced
this pull request
Jul 8, 2025
cursor Bot
pushed a commit
that referenced
this pull request
Aug 5, 2026
…y (MUST FIX #2) handleRequestError built its timeout NetworkError message directly from error.config?.url, which can carry query-string credentials/tokens. Route it through the existing redactEndpoint() helper instead. Also wraps every real-HTTP-server test in http-client-hang.test.ts in try/finally so a failing assertion cannot leave a listening socket behind, and adds a regression test asserting a timeout error message never contains a raw query-string secret. Co-authored-by: HardlyDifficult <hardlydiff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.