Switch package to restricted - #3
Merged
Merged
Conversation
HardlyDifficult
enabled auto-merge (squash)
July 8, 2025 18:55
cursor Bot
pushed a commit
that referenced
this pull request
Aug 5, 2026
…#3) isTimeoutError treated any axios error with code ETIMEDOUT the same as our own configured socket-inactivity timeout, making it non-retryable. Empirically (axios 1.18.1, the version pinned in package.json), the Node http adapter's createTimeoutError() always uses ECONNABORTED for our own configured timeout, since we never set transitional.clarifyTimeoutError (its default is false). A raw ETIMEDOUT only ever comes from Node's own connect-phase failure (e.g. 'connect ETIMEDOUT <ip>:<port>'), a distinct and genuinely transient condition that should remain retryable, matching pre-PR behavior for that failure mode. isTimeoutError now checks for ECONNABORTED only. Adds a regression test simulating a connect-phase ETIMEDOUT (code: 'ETIMEDOUT', syscall: 'connect') and asserting it is retried like other transient network failures. Co-authored-by: HardlyDifficult <hardlydiff@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.