Skip to content

Fix build script executable mode preservation#68

Merged
ejball merged 2 commits into
masterfrom
ejball/fix-build-script-executable-mode
Jun 5, 2026
Merged

Fix build script executable mode preservation#68
ejball merged 2 commits into
masterfrom
ejball/fix-build-script-executable-mode

Conversation

@ejball
Copy link
Copy Markdown
Member

@ejball ejball commented Jun 5, 2026

No description provided.

@ejball ejball requested review from bgrainger and ddunkin as code owners June 5, 2026 18:17
Comment thread conventions/build-script/convention.ps1
Copy link
Copy Markdown
Member

@bgrainger bgrainger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know. If you tested it and it works, sure?

)

# Windows Git does not derive the executable bit from the filesystem.
if ($IsWindows) {
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What runner do we use to auto-apply conventions?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ejball ejball merged commit 9a1e071 into master Jun 5, 2026
4 checks passed
@ejball ejball deleted the ejball/fix-build-script-executable-mode branch June 5, 2026 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants