Skip to content
This repository was archived by the owner on Jul 19, 2024. It is now read-only.

Always create a copy of the TextPointers in TextAdaptor.GetBoundingRectanges#2

Merged
bgrainger merged 1 commit intoFaithlife:stablefrom
martinpotter:stable
May 3, 2023
Merged

Always create a copy of the TextPointers in TextAdaptor.GetBoundingRectanges#2
bgrainger merged 1 commit intoFaithlife:stablefrom
martinpotter:stable

Conversation

@martinpotter
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Member

@bgrainger bgrainger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any chance of getting this change accepted upstream? Getting patches into dotnet/wpf will let us eventually switch from a custom package to the in-the-box one, which could reduce long-term maintenance burden.

@martinpotter
Copy link
Copy Markdown
Author

Is there any chance of getting this change accepted upstream? Getting patches into dotnet/wpf will let us eventually switch from a custom package to the in-the-box one, which could reduce long-term maintenance burden.

We would probably need to come up with a standalone repro for the crash, open an issue and a PR.

…ctanges

This method can modify the TextPointer so always make a copy instead of only when using the ITextView's TextSegment's TextPointers.
@bgrainger
Copy link
Copy Markdown
Member

The build is probably failing because it was opened from a fork. If you pushed a branch to this repo, I'm guessing it would succeed. We don't need to do that to merge this, though.

@bgrainger bgrainger merged commit 0f561a4 into Faithlife:stable May 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants