Skip to content

890 plane does not follow guided commands#891

Merged
Kwash67 merged 4 commits intomainfrom
890-plane-does-not-follow-guided-commands
Nov 30, 2025
Merged

890 plane does not follow guided commands#891
Kwash67 merged 4 commits intomainfrom
890-plane-does-not-follow-guided-commands

Conversation

@Kwash67
Copy link
Copy Markdown
Contributor

@Kwash67 Kwash67 commented Nov 28, 2025

No description provided.

@Kwash67 Kwash67 requested review from a team and Copilot November 28, 2025 23:20
@Kwash67 Kwash67 linked an issue Nov 28, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes an issue where fixed-wing aircraft (planes) do not properly follow guided reposition commands. The solution implements vehicle-type-specific command handling, using MISSION_ITEM_INT for planes and SET_POSITION_TARGET_GLOBAL_INT for multirotors.

Key changes:

  • Added conditional logic to use different MAVLink commands based on aircraft type
  • Imported VehicleType enum for type checking
  • Enhanced documentation explaining the approach for each vehicle type

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread radio/app/controllers/navController.py Outdated
Comment thread radio/app/controllers/navController.py Outdated
Copy link
Copy Markdown
Member

@1Blademaster 1Blademaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me

@Kwash67 Kwash67 merged commit 01f8373 into main Nov 30, 2025
6 checks passed
@Kwash67 Kwash67 deleted the 890-plane-does-not-follow-guided-commands branch November 30, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plane does not follow guided commands

3 participants