Skip to content

SealSpellbookRecipe and associated ingredient classes seem to be unused #1232

Description

@Robotgiggle

Minecraft version

1.21.1

Hex Casting version

0.12.0

Issue description

The SealSpellbookRecipe class, along with the various classes and methods used to provide its ingredients (IXplatAbstractions.getUnsealedIngredient(), FabricXplatImpl.getUnsealedIngredient(), ForgeXplatImpl.getUnsealedIngredient(), FabricUnsealedIngredient, and ForgeUnsealedIngredient) seem to be entirely unused at the moment. The ingame spellbook-sealing recipe is handled via the SealThingsRecipe class instead, and commenting out the classes mentioned above does not prevent it from working on either platform.

The only reason I haven't deleted these files outright as deprecated content is that I suspect they may have been used at one point to make the sealing recipe show up in recipe viewers. Such a feature currently does not exist, so far as I've been able to tell in testing, but I believe it did exist at one point. If we ever want to restore it, these classes may be useful for doing that.

Alternatively, if these classes are not necessary to (re)implement such a feature, they should be removed as nothing is actually using them.

Metadata

Metadata

Assignees

No one assigned

    Labels

    1.21apiAPI-related enhancements/bugs/optimizationsbugSomething isn't workingneeds investigation

    Type

    No type

    Projects

    Status
    📋 Backlog

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions