Skip to content

fix: temporary nexus binding should not overwrite permanent bind when given non-nexus position - #218

Merged
Robotgiggle merged 2 commits into
FallingColors:mainfrom
pythonmcpi:patch-1
May 22, 2026
Merged

fix: temporary nexus binding should not overwrite permanent bind when given non-nexus position#218
Robotgiggle merged 2 commits into
FallingColors:mainfrom
pythonmcpi:patch-1

Conversation

@pythonmcpi

Copy link
Copy Markdown
Contributor

See pull request title.
It might be a good idea to also wipe any existing temporary bind, but I don't see too much utility in implementing that and doing that would require more testing.

@Robotgiggle

Copy link
Copy Markdown
Member

Removing an existing temp bind seems like it would be pretty easy. You could just use the same setup as lines 56-58 but remove the tag instead of setting it.

Also, regardless of whether you decide to do that or not, the new behavior should be documented in the book.

@pythonmcpi

Copy link
Copy Markdown
Contributor Author

I'll add the temporary binding wiping. However, I would argue that this change is not new behavior, and simply changes existing behavior to align with player expectations (i.e. that the temporary binding pattern will never affect my permanently bound nexus).

@Robotgiggle

Copy link
Copy Markdown
Member

Fair enough.

@Robotgiggle
Robotgiggle merged commit ec92502 into FallingColors:main May 22, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants