fix: temporary nexus binding should not overwrite permanent bind when given non-nexus position - #218
Merged
Merged
Conversation
… given non-nexus position
Member
|
Removing an existing temp bind seems like it would be pretty easy. You could just use the same setup as lines 56-58 but remove the tag instead of setting it. Also, regardless of whether you decide to do that or not, the new behavior should be documented in the book. |
Contributor
Author
|
I'll add the temporary binding wiping. However, I would argue that this change is not new behavior, and simply changes existing behavior to align with player expectations (i.e. that the temporary binding pattern will never affect my permanently bound nexus). |
Member
|
Fair enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See pull request title.
It might be a good idea to also wipe any existing temporary bind, but I don't see too much utility in implementing that and doing that would require more testing.