feat!: close the #83 Newtonsoft migration tree — STJ-6 + STJ-2 tail (#119, #115) - #174
Merged
Merged
Conversation
, #115) Last-mile Newtonsoft removal. No Fallout source file uses Newtonsoft.Json anymore. The .dll survives in the closure only as a true transitive of NuGet.Packaging and Serilog.Formatting.Compact.Reader. The Newtonsoft.Json PackageVersion is gone from Directory.Packages.props entirely. Migrations in this PR: - Fallout.Common/Tools/Slack/SlackTasks.cs: JsonConvert.SerializeObject -> JsonSerializer.Serialize. [JsonProperty] -> [JsonPropertyName] on the SlackMessageActionButton.Type hand-written member. - Fallout.Common/Tools/Teams/Teams.Extensions.cs: [JsonProperty("@type")] / [JsonProperty("@context")] -> [JsonPropertyName(...)]. - Fallout.Common/Tools/Twitter/TwitterTasks.cs: JObject.Parse error-parsing swapped to JsonNode.Parse. - Fallout.Common/CI/GitHubActions/GitHubActions.cs: Lazy<JObject> _eventContext -> Lazy<JsonObject>. Public GitHubEvent property type changes from JObject -> JsonObject (v11 API break, was tracked in code comment). Accessors updated. - Fallout.Build/Execution/Extensions/ArgumentsFromParametersFileAttribute.cs (#115 STJ-2 tail): parameters.json reading swapped from JObject/JProperty to JsonObject indexer. ToObject<T> -> GetValue<T> / Deserialize. - Fallout.Utilities.Net: HttpRequest.Content.cs and HttpResponse.Body.cs stripped of all [Obsolete] Newtonsoft overloads. Default WithJsonContent / GetBodyAsJson now serialize via STJ. JsonSerializerOptions overloads remain for explicit configuration. Package refs dropped: - Newtonsoft.Json PackageReference removed from Fallout.Utilities.Net.csproj. - Newtonsoft.Json PackageVersion removed from Directory.Packages.props. Tests: 425/425 pass across 10 DLLs. Closes #119 (STJ-6), #115 (STJ-2), #83 (parent tracker). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Last-mile Newtonsoft removal. After this lands, no Fallout source file uses
Newtonsoft.Json— the.dllsurvives in the closure only as a transitive ofNuGet.Packaging(Fallout.Tooling) andSerilog.Formatting.Compact.Reader(Fallout.Build). TheNewtonsoft.JsonPackageVersionis removed fromDirectory.Packages.propsentirely.Closes the entire
#83STJ-migration tree:ArgumentsFromParametersFileAttribute)Fallout.Utilities.Text.JsonNewtonsoft surface removed*Tasks.csAPI integrations on STJ ← this PRMigrations in this PR
Fallout.Common/Tools/Slack/SlackTasks.csJsonConvert.SerializeObject→JsonSerializer.Serialize.[JsonProperty]→[JsonPropertyName]onSlackMessageActionButton.Type.Fallout.Common/Tools/Teams/Teams.Extensions.cs[JsonProperty(\"@type\")]/[JsonProperty(\"@context\")]→[JsonPropertyName(...)].Fallout.Common/Tools/Twitter/TwitterTasks.csJObject.ParsetoJsonNode.Parse.Fallout.Common/CI/GitHubActions/GitHubActions.csLazy<JObject> _eventContext→Lazy<JsonObject>. PublicGitHubEventproperty type changes fromJObject→JsonObject(v11 API break — was tracked in code comment).Fallout.Build/Execution/Extensions/ArgumentsFromParametersFileAttribute.cs(#115 tail)parameters.jsonreading:JObject.Parse+JProperty+ToObject<T>→JsonNode.Parse+ indexer +GetValue<T>/Deserialize.Fallout.Utilities.Net/HttpRequest.Content.csWithJsonContentnow uses STJ.[Obsolete]JsonSerializerSettingsoverload removed.Fallout.Utilities.Net/HttpResponse.Body.csGetBodyAsJson<T>now uses STJ. All[Obsolete]Newtonsoft overloads removed (includingJObject-returning ones).GetBodyAsJsonObjectreturnsJsonObject.Package refs dropped
Newtonsoft.JsonPackageReference removed fromFallout.Utilities.Net.csproj.Newtonsoft.JsonPackageVersion removed fromDirectory.Packages.props.Closure check
Test plan
dotnet build fallout.slnx— 0 errors.dotnet test fallout.slnx— 425/425 pass across 10 DLLs.Closes
🤖 Generated with Claude Code