Skip to content

Use different ansi escape code for yellow on gitlab - #390

Merged
ChrisonSimtian merged 3 commits into
Fallout-build:mainfrom
ITaluone:fix/logo-color-gitlab
Jun 25, 2026
Merged

Use different ansi escape code for yellow on gitlab#390
ChrisonSimtian merged 3 commits into
Fallout-build:mainfrom
ITaluone:fix/logo-color-gitlab

Conversation

@ITaluone

@ITaluone ITaluone commented Jun 16, 2026

Copy link
Copy Markdown
Contributor

Gitlab does not support "24-bit true-color ANSI sequence" so the logo appears white instead of yellow.

I confirm that the pull-request:

  • Follows the contribution guidelines
  • Is based on my own work
  • Is in compliance with my employer

Merge preference: ( ) squash (default) ( ) rebase

@ITaluone
ITaluone requested a review from a team as a code owner June 16, 2026 11:19
@ITaluone
ITaluone force-pushed the fix/logo-color-gitlab branch from 35cf67f to 50089c5 Compare June 16, 2026 11:46

@ChrisonSimtian ChrisonSimtian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm thanks for fixing this :-)

@ChrisonSimtian ChrisonSimtian added the Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved label Jun 18, 2026
@ChrisonSimtian
ChrisonSimtian force-pushed the fix/logo-color-gitlab branch from d99d54b to f260faf Compare June 24, 2026 21:26
@ChrisonSimtian
ChrisonSimtian merged commit 905593e into Fallout-build:main Jun 25, 2026
1 check passed
@ITaluone
ITaluone deleted the fix/logo-color-gitlab branch June 25, 2026 05:06
@ChrisonSimtian ChrisonSimtian added the enhancement New feature or request label Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants