Remove IHasChangelog / IHazChangelog build component - #432
Conversation
| Prerelease = Prerelease, | ||
| Draft = Draft, | ||
| Body = ChangelogTasks.ExtractChangelogSectionNotes(ChangelogFile).JoinNewLine() | ||
| Body = "" |
There was a problem hiding this comment.
Here, I don't know what actually should go here.. 🤷♂️
|
I don't think this is the solution. That |
ChrisonSimtian
left a comment
ChrisonSimtian
left a comment
There was a problem hiding this comment.
I'm happy for us to look into the Build.cs change (although PR #433 will fix the root cause), the rest we should probably park on the side for now.
| [ShutdownDotNetAfterServerBuild] | ||
| partial class Build | ||
| : FalloutBuild, | ||
| IHasChangelog, |
There was a problem hiding this comment.
yes that will unbreak our internal build now that Changelog.md doesnt exist anymore :-)
There was a problem hiding this comment.
No, it won't, as our build implements ICreateGitHubRelease and that one inherits IHasChangeLog
| namespace Fallout.Components; | ||
|
|
||
| [ParameterPrefix(GitHubRelease)] | ||
| public interface ICreateGitHubRelease : IHasGitRepository, IHasChangelog |
There was a problem hiding this comment.
this we should look into, however this is a breaking change that would break GH releases for people.
Current behaviour seems to be that it does the changelog based on the Changelog.md
Since this is its own mechanism, I'm quite happy to pull this apart at some point. Just not here and now
ChrisonSimtian
added
breaking-change
|
As discussed, we'll solve this in #433 |
3 participants
I don't know if this is the correct way of dealing with the deleted changelog.. But worth a try...