Skip to content

Fix Pack when CHANGELOG.md is missing - #437

Merged
ChrisonSimtian merged 1 commit into
Fallout-build:mainfrom
dennisdoomen:fix-pack-missing-changelog-url
Jun 29, 2026
Merged

Fix Pack when CHANGELOG.md is missing#437
ChrisonSimtian merged 1 commit into
Fallout-build:mainfrom
dennisdoomen:fix-pack-missing-changelog-url

Conversation

@dennisdoomen

@dennisdoomen dennisdoomen commented Jun 28, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Problem

  • Pack crashed when CHANGELOG.md was missing.
  • GetNuGetReleaseNotes appended a GitHub browse URL using automatic item-type detection, which threw when the file did not exist.

Outcome

  • Force changelog browse links to use GitHubItemType.File when building NuGet release notes.
  • Add regression test for missing changelog + GitHub repository path.

@dennisdoomen
dennisdoomen requested a review from a team as a code owner June 28, 2026 07:06
@dennisdoomen dennisdoomen added the target/vCurrent Targets the current version label Jun 28, 2026
@dennisdoomen
dennisdoomen marked this pull request as draft June 28, 2026 07:27
@dennisdoomen dennisdoomen added the bug Something isn't working label Jun 28, 2026
@dennisdoomen
dennisdoomen marked this pull request as ready for review June 28, 2026 07:36
@dennisdoomen dennisdoomen mentioned this pull request Jun 28, 2026
Merged
@dennisdoomen
dennisdoomen force-pushed the fix-pack-missing-changelog-url branch 2 times, most recently from db83472 to d810d5e Compare June 28, 2026 07:55
@ChrisonSimtian ChrisonSimtian added the Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved label Jun 28, 2026
@ChrisonSimtian
ChrisonSimtian force-pushed the fix-pack-missing-changelog-url branch from d810d5e to 71987cd Compare June 29, 2026 01:58
@ChrisonSimtian

ChrisonSimtian commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

sorry for merging this on your behalf, but I really wanna get the build fixed :-)

@ChrisonSimtian
ChrisonSimtian merged commit 7c5ed84 into Fallout-build:main Jun 29, 2026
1 check passed
@dennisdoomen

dennisdoomen commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator Author

sorry for merging this on your behalf, but I really wanna get the build fixed :-)

Of course. No need to apologize for that.

@dennisdoomen
dennisdoomen deleted the fix-pack-missing-changelog-url branch June 29, 2026 04:39
This was referenced Aug 7, 2026
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ChrisonSimtian ChrisonSimtian ChrisonSimtian approved these changes

Assignees

No one assigned

Labels

bug Something isn't working Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved target/vCurrent Targets the current version

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dennisdoomen @ChrisonSimtian