Skip to content

Add ClickOnce settings definition for MSBuild - #466

Merged
ITaluone merged 2 commits into
Fallout-build:mainfrom
ITaluone:feat/clickonce-settings-msbuild
Jul 7, 2026
Merged

Add ClickOnce settings definition for MSBuild#466
ITaluone merged 2 commits into
Fallout-build:mainfrom
ITaluone:feat/clickonce-settings-msbuild

Conversation

@ITaluone

@ITaluone ITaluone commented Jul 3, 2026

Copy link
Copy Markdown
Contributor

Quick win, + need it for myself: nuke-build/nuke#1546

@ITaluone
ITaluone requested a review from a team as a code owner July 3, 2026 09:00
Comment thread src/Fallout.Common/Tools/MSBuild/MSBuild.json
@ChrisonSimtian ChrisonSimtian added the Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved label Jul 4, 2026
Comment thread src/Fallout.Common/Tools/MSBuild/MSBuild.json
Comment thread src/Fallout.Common/Tools/MSBuild/MSBuild.json
@ITaluone
ITaluone force-pushed the feat/clickonce-settings-msbuild branch from 69a3543 to 1075685 Compare July 5, 2026 13:21
@ITaluone
ITaluone requested a review from dennisdoomen July 5, 2026 13:24
Comment thread src/Fallout.Common/Tools/MSBuild/MSBuild.json Outdated
@ITaluone
ITaluone force-pushed the feat/clickonce-settings-msbuild branch from 1075685 to 0a2b9eb Compare July 6, 2026 05:27
@ChrisonSimtian ChrisonSimtian removed the Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved label Jul 7, 2026
@ChrisonSimtian
ChrisonSimtian self-requested a review July 7, 2026 09:44
@ChrisonSimtian
ChrisonSimtian dismissed dennisdoomen’s stale review July 7, 2026 09:46

Changes have been made now, dismissing the change request

@ChrisonSimtian ChrisonSimtian left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ITaluone good to go :-) Thanks for adding the help bits as well

@ChrisonSimtian ChrisonSimtian added the Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved label Jul 7, 2026
@ITaluone

ITaluone commented Jul 7, 2026

Copy link
Copy Markdown
Contributor Author

Should this wait for @dennisdoomen ?

@ITaluone
ITaluone force-pushed the feat/clickonce-settings-msbuild branch from 0a2b9eb to 846bb4f Compare July 7, 2026 09:51
@ITaluone
ITaluone enabled auto-merge (rebase) July 7, 2026 10:16
@ITaluone
ITaluone force-pushed the feat/clickonce-settings-msbuild branch from 846bb4f to 9bf9707 Compare July 7, 2026 10:29
@ITaluone
ITaluone merged commit b5088e0 into Fallout-build:main Jul 7, 2026
1 check passed
@ITaluone
ITaluone deleted the feat/clickonce-settings-msbuild branch July 7, 2026 10:34
@ChrisonSimtian ChrisonSimtian added the enhancement New feature or request label Jul 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Can Merge These PRs are just waiting to be merged, nothing more to do and maintainer has approved enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants