Add XmlAdd extension to XmlTasks - #489
Merged
Merged
Conversation
ITaluone
force-pushed
the
feat/xml-task-for-adding
branch
from
July 13, 2026 07:08
1e390a1 to
5c0bd19
Compare
ITaluone
force-pushed
the
feat/xml-task-for-adding
branch
3 times, most recently
from
July 13, 2026 07:24
59c3adb to
e47d38c
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new XmlTasks.XmlAdd API plus a small fluent XmlElementBuilder to make inserting XML nodes (e.g., updating nuget.config feeds) more convenient within Fallout’s XML utilities.
Changes:
- Add
XmlTasks.XmlAdd(...)overloads to append new XML content at an XPath location. - Introduce
XmlElementBuilderfor fluent construction ofXElementtrees. - Add specs + Verify snapshot covering common and “real world”
nuget.configusage.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/Fallout.Common.Specs/XmlTasksSpecs.cs | Adds specs for XmlAdd (builder + string) and XmlElementBuilder behaviors, plus a Verify-based nuget.config scenario. |
| tests/Fallout.Common.Specs/XmlTasksSpecs.A_real_world_use_case.verified.txt | Snapshot for expected pretty-printed output after adding a package source. |
| src/Fallout.Common/IO/XmlTasks.cs | Adds XmlAdd, refactors saving into Save, and adjusts some method formatting. |
| src/Fallout.Common/IO/XmlElementBuilder.cs | New fluent builder for producing XElement instances used by XmlAdd and tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
ITaluone
force-pushed
the
feat/xml-task-for-adding
branch
3 times, most recently
from
July 13, 2026 08:13
f866458 to
878bef9
Compare
ChrisonSimtian
approved these changes
Jul 13, 2026
ITaluone
added
enhancement
ITaluone
force-pushed
the
feat/xml-task-for-adding
branch
from
July 13, 2026 09:13
878bef9 to
8e634f2
Compare
# Conflicts: # tests/Fallout.Common.Specs/XmlTasksSpecs.cs
ITaluone
force-pushed
the
feat/xml-task-for-adding
branch
from
July 13, 2026 11:22
8e634f2 to
8fe11b9
Compare
ITaluone
enabled auto-merge (rebase)
July 13, 2026 11:22
ITaluone
disabled auto-merge
July 13, 2026 11:23
Contributor
|
Out of curiosity... how many approvals do we seek before merging? |
avidenic
reviewed
Jul 14, 2026
avidenic
approved these changes
Jul 14, 2026
ITaluone
force-pushed
the
feat/xml-task-for-adding
branch
from
July 14, 2026 05:23
8eb4259 to
a17f2c3
Compare
ITaluone
force-pushed
the
feat/xml-task-for-adding
branch
from
July 14, 2026 05:41
a17f2c3 to
8ef16e5
Compare
ITaluone
enabled auto-merge (rebase)
July 14, 2026 05:43
This was referenced Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #488
Adds an additional
XmlElementBuilderfor convenient node building