Skip to content

fix: Load Profiler chart drawn when disabled#725

Merged
crazyplayy merged 4 commits into
masterfrom
720-fix-load-profiler-chart-drawn-when-disabled
Jul 4, 2023
Merged

fix: Load Profiler chart drawn when disabled#725
crazyplayy merged 4 commits into
masterfrom
720-fix-load-profiler-chart-drawn-when-disabled

Conversation

@crazyplayy

@crazyplayy crazyplayy commented Jul 3, 2023

Copy link
Copy Markdown
Contributor

Description

Added flag isLoadProfileEnabled to the run attributes, and passed the flag to the component building the chart, making it only draw the Expected Hits line during a Test execution if the Load Profiler was enabled.

Closes #720

Checklist

  • The commit message follows our guidelines
  • Tests for the respective changes have been added
  • The labels and/or milestones were added

@crazyplayy crazyplayy added bug Something isn't working api Maestro API frontend labels Jul 3, 2023
@crazyplayy crazyplayy self-assigned this Jul 3, 2023
@crazyplayy crazyplayy linked an issue Jul 3, 2023 that may be closed by this pull request
@dyegowermelinger dyegowermelinger changed the title isLoadProfileEnabled asserts if chart should drawn fix: isLoadProfileEnabled asserts if chart should drawn Jul 3, 2023
@crazyplayy crazyplayy changed the title fix: isLoadProfileEnabled asserts if chart should drawn fix: Load Profiler chart drawn when disabled Jul 3, 2023
@crazyplayy
crazyplayy merged commit 199d3e8 into master Jul 4, 2023
@crazyplayy
crazyplayy deleted the 720-fix-load-profiler-chart-drawn-when-disabled branch July 4, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api Maestro API bug Something isn't working frontend

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: Load Profiler Chart drawn when disabled

4 participants