Skip to content

Fix issue in dates used in rules matching#123

Merged
jdromeiro merged 34 commits intomasterfrom
feat/93/fix_applicability_end_date_rules
Mar 14, 2023
Merged

Fix issue in dates used in rules matching#123
jdromeiro merged 34 commits intomasterfrom
feat/93/fix_applicability_end_date_rules

Conversation

@jdromeiro
Copy link
Copy Markdown
Contributor

@jdromeiro jdromeiro commented Mar 3, 2023 •
edited
Loading

Description

  • Changes current Tests namespaces in IntegrationTests to Scenarios
  • Creates Features namespaces in IntegrationTests
  • Creates tests for verifying correct matching of rule dates
  • Fixes issue with rules dates matching -> Closes Fix the applicability of the EndDate of a Rule #93 .
  • Fixes typo in PriorityCriteria
  • Replaces explicit variables by implicit variables (var) in Rules.Engine

Change checklist

  • Code follows the code rules guidelines of this project
  • Commit messages follow the commit rules of this project
  • I have self-reviewed my changes before submitting this pull request
  • I have covered new/changed code with new tests and/or adjusted existent ones
  • I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@jdromeiro jdromeiro changed the title Add test for assuring rules matching Fix issue in rules matching Mar 3, 2023
@jdromeiro jdromeiro changed the title Fix issue in rules matching [WIP] Fix issue in rules matching Mar 3, 2023
@jdromeiro jdromeiro mentioned this pull request Mar 5, 2023
Closed
5 tasks
@jdromeiro jdromeiro added the bug Something isn't working label Mar 5, 2023
@jdromeiro jdromeiro self-assigned this Mar 5, 2023
jdromeiro added 19 commits March 6, 2023 10:27
@jdromeiro
Set dates parameters in matchasync as full datettimes
130274f
@jdromeiro
merged
72afe09
@jdromeiro
Changed tests to include also datetime during the day
054ec74
@jdromeiro
changes test names
566cbd9
@jdromeiro
small change
d6e7a1c
@jdromeiro
Re-added PriotityCriteria as obsolete
d76a04a
@jdromeiro
replaced explicit types by implicit types in tests
965e320
@jdromeiro
added obsolete method to irulesengineoptions
15185b8
@jdromeiro
minor changes
6d947bd
@jdromeiro
more replacement of explicit variables by var
2f852e5
@jdromeiro
Made references to projects within solution to be made all by project…
c5e5cc4 
… reference
@jdromeiro
removed dotnet-build step to replace packages by projects
9eb09f0
@jdromeiro
Completed last commit
5747d43
@jdromeiro
Merge branch 'feat/93/fix_applicability_of_rules_pre-work' into feat/…
84aa07f 
…93/fix_applicability_end_date_rules
@jdromeiro
Merge branch 'feat/93/set_rulesframework_dependencies_as_project' int…
1649ffc 
…o feat/93/fix_applicability_end_date_rules
@jdromeiro
Moved Providers.InMemory namespace to Rules.Framework assembly
20d9f3b
@jdromeiro
removed License.MD link
40d91a8
@jdromeiro
Merge branch 'feat/93/set_rulesframework_dependencies_as_project' int…
c8a9c49 
…o feat/93/fix_applicability_of_rules_pre-work
@jdromeiro
resolved conflicts
da5b6a2
@jdromeiro jdromeiro added the enhancement New feature or request label Mar 10, 2023
@jdromeiro jdromeiro changed the title [WIP] Fix issue in rules matching Fix issue in dates used in rules matching Mar 10, 2023
@jdromeiro
Copy link
Copy Markdown
Contributor Author

jdromeiro commented Mar 10, 2023 •
edited
Loading

ℹ️
The logic for the definition of the dates filter was based on the first answer on this thread.

martinhonovais
martinhonovais previously approved these changes Mar 10, 2023
View reviewed changes
@jdromeiro jdromeiro requested a review from luispfgarces March 13, 2023 10:27
luispfgarces
luispfgarces reviewed Mar 13, 2023
View reviewed changes
Comment thread src/Rules.Framework/RulesEngineOptions.cs Outdated
@jdromeiro jdromeiro merged commit 5606a30 into master Mar 14, 2023
@luispfgarces luispfgarces deleted the feat/93/fix_applicability_end_date_rules branch March 22, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@martinhonovais martinhonovais martinhonovais approved these changes

@luispfgarces luispfgarces luispfgarces approved these changes

Assignees

@jdromeiro jdromeiro

Labels

bug Something isn't working enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Fix the applicability of the EndDate of a Rule

3 participants

@jdromeiro @martinhonovais @luispfgarces