Skip to content

Fix issue in rules matching (pre-work)#127

Closed
jdromeiro wants to merge 12 commits intomasterfrom
feat/93/fix_applicability_of_rules_pre-work
Closed

Fix issue in rules matching (pre-work)#127
jdromeiro wants to merge 12 commits intomasterfrom
feat/93/fix_applicability_of_rules_pre-work

Conversation

@jdromeiro
Copy link
Copy Markdown
Contributor

@jdromeiro jdromeiro commented Mar 5, 2023

Description

Changes to rules framework assembly necessary for fixing the rules date matching issue that will be resolved in #123 .
It includes:

  • Modification of dates in RulesEngine.MatchManyAsync()
  • Fix of typo in PriorityCriteria
  • Replacement of explicit variables by implicit variables (var)

Change checklist

  • Code follows the code rules guidelines of this project
  • Commit messages follow the commit rules of this project
  • I have self-reviewed my changes before submitting this pull request
  • I have covered new/changed code with new tests and/or adjusted existent ones
  • I have made changes necessary to update the documentation accordingly

Please also check the I want to contribute guidelines and make sure you have done accordingly.

Disclaimer

By sending us your contributions, you are agreeing that your contribution is made subject to the terms of our Contributor Ownership Statement

@jdromeiro jdromeiro self-assigned this Mar 5, 2023
@jdromeiro jdromeiro added the bug Something isn't working label Mar 5, 2023
@luispfgarces luispfgarces linked an issue Mar 6, 2023 that may be closed by this pull request
carlosgoias
carlosgoias previously approved these changes Mar 6, 2023
@jdromeiro jdromeiro closed this Mar 9, 2023
@jdromeiro jdromeiro deleted the feat/93/fix_applicability_of_rules_pre-work branch March 9, 2023 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants