[OoT] Importing scenes with transition actors whose room index = 255 fails

[kurethedead]

Ex. Inside Jabu Jabu, Lon Lon Ranch. These scenes have transition actors whose front room index = 255, far outside the range of the room count. These scenes fail to import.

[Yanis002]

the new assets system "fixed" this as it seems to use -1 directly, which causes to read the last element of the room object list, that said fast64 still need a proper check for that since it's basically UB now

[Yanis002]

what I said previously is wrong, I mixed up the camera index and the room index, I checked and there's only 3 cases of a room index being -1:

• 1 in an alternate header from jabu (cutscene 1)
• 2 also in an alternate header in the ranch (cutscene 2)

I feel like this was a mistake from the devs? I'm not sure if we should fix it by forcing -1 room indices to be 0 or if we should consider -1 and let the side having an empty object (this would probably prevent exporting though), when the room index is -1 it means "invalid room" so yeah idk

I think I'm going with the second option, I want to keep the import consistent with the data

[Yanis002]

I checked where are those doors, the jabu one is an unused door that leads to barinade's room, so I guess it makes sense that it's -1 actually:

for the ranch ones I can't tell if it's a mistake or a left-over, it seems like a mistake? but on the other hand I can see a world where those places would be a part of the outside area: