Skip to content

Conversation

@Yanis002
Copy link
Collaborator

This addresses random issues:

  • fix [OoT] Importing scenes with transition actors whose room index = 255 fails #418, when the room index is 255 or -1 it will set the corresponding side's room object to None and also won't parent to the front room, it will also explicitely say that transition actor has an issue, since this only affects 2 scenes for 3 actors in total I think this is completely fine, the doors are unused anyway since they're all in cutscene setups
  • fixed a strange bug where importing with an invalid custom scene name would somehow create a folder
  • it was brought to my attention that doors got a parameter I never knew about, at 0x0400 (or 1 << 10) there should be an index, which should be the that transition actor's position in the transition actor list, should be harmless for unmodified door actors (see func_800C0D34 in z_play.c, it's used for "OnePointDemo" cutscenes)
  • made the quick import feature check for both the extracted assets folder and the root one, I wanted to fix that issue entirely but it became bigger than I expected so it will be for another PR
  • fixed light settings import with recent decomp changes, also this makes the exporter use the new macro for blend rate/fog near combo (a backwards compatibility option was added for convenience)
  • fix [OoT] Link gets imported with a ridiculously massive scale #600, the bug was more or less introduced in [OoT] Update actor scale's default value #508, the core issue was the importer never checking for Link to set the right scale

@Yanis002 Yanis002 added bug Something isn't working oot Has to do with the Ocarina of Time 64 side labels Nov 14, 2025
Copy link
Contributor

@Reonu Reonu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Importing link is fine
  • Exporting transition actors is fixed after you latest commit
  • Importing lon lon ranch and jabu jabu gives the expected result
  • Quick import partially works like you mentioned, it's not more broken than before so it's ok
  • Importing a wrong scene no longer creates a folder which is good (???????)
  • Importing lights in recent decomp seems ok

seems ok

@Yanis002 Yanis002 added the merge soon Will be merged in a few days at most if nothing else comes up label Nov 15, 2025
@Yanis002 Yanis002 merged commit e2c786d into Fast-64:main Nov 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working merge soon Will be merged in a few days at most if nothing else comes up oot Has to do with the Ocarina of Time 64 side

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[OoT] Link gets imported with a ridiculously massive scale [OoT] Importing scenes with transition actors whose room index = 255 fails

2 participants