Fix URL encoding of route values in routeless test helpers - #1171
Open
Benziza wants to merge 1 commit into
Open
Conversation
2 tasks
Author
|
Companion documentation PR: FastEndpoints/Documentation#40 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URL-encode hydrated route parameter values generated by
GetTestUrlFor().Route values containing reserved URI characters such as
#,?, or spaces are currently inserted directly into the generated URL. This can truncate or alter the request before it reaches the endpoint.Reproduction
Given the following route:
And this request value:
GetTestUrlFor()currently generates:The actual request path becomes:
Fix
Encode hydrated route parameter values with
Uri.EscapeDataString()while preserving unresolved route placeholders.Catch-all route handling is intentionally outside the scope of this change.
Tests
HttpClientExtensionsTests: 12/12 passedUnit.FastEndpoints: 346/346 passed