ci: let setup-soldr float soldr binary#1003
Merged
Merged
Conversation
📝 WalkthroughWalkthroughCI workflows across the repository are updated to use the floating ChangesUnpin setup-soldr across workflows
Estimated code review effort: 2 (Simple) | ~10 minutes probe_rs.rs NormalizedPath refactor
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
version: 0.8.0input from every setup-soldr workflow step so setup-soldr controls the soldr binary version.zackees/setup-soldr@v0.9.66tozackees/setup-soldr@v0;v0currently points at setup-soldrmain, whose action default is soldr0.8.0without a repo-local binary pin.soldr 0.8.0assertion to a smoke check thatsoldr --versionreturns a soldr version string.ban_std_pathbufgate that was blocking this PR on currentmain.Closes #997
Validation
gh api repos/zackees/setup-soldr/git/refs/tags/v0 --jq '.object.sha'matchesgh api repos/zackees/setup-soldr/commits/main --jq '.sha'(18b1e0f546c53837320e472325ea695bab96f091).rg -n -F 'zackees/setup-soldr@v0.9.66' .github cireturned no matches.rg -n -F 'version: "0.8.0"' .github cireturned no matches.rg -n -F 'test "$version" = "soldr' .github cireturned no matches.rg -n 'PathBuf' crates/fbuild-deploy/src/probe_rs.rsreturned no matches.git diff --checkuv run --no-project python ci/render_workflows.py --checksoldr cargo fmt --checkSummary by CodeRabbit