Skip to content

fix(dylint): normalize remaining workspace paths - #1193

Merged
zackees merged 1 commit into
mainfrom
fix/issue-1155-dylint-workspace
Jul 25, 2026
Merged

fix(dylint): normalize remaining workspace paths#1193
zackees merged 1 commit into
mainfrom
fix/issue-1155-dylint-workspace

Conversation

@zackees

@zackees zackees commented Jul 25, 2026

Copy link
Copy Markdown
Member

Summary

  • migrate the benchmark comparison harness from raw PathBuf fields/helpers to fbuild_core::path::NormalizedPath
  • replace benchmark and ESP cache hand-rolled slash rewriting with NormalizedPath::display_slash()
  • make the workspace-wide Dylint 6.0.1 scan clean after chore(dylint): upgrade stack to 6.0.1 #1192 exposed these previously hidden violations

Validation

  • soldr cargo check -p fbuild-bench-fastled-examples --all-targets
  • soldr cargo test -p fbuild-bench-fastled-examples (6 passed)
  • soldr cargo test -p fbuild-build-esp cache_key_normalizes_windows_style_project_paths_in_flags
  • soldr cargo fmt --all -- --check
  • no lint or allowlist changes

Follow-up to #1155 and #1192.

Use the shared NormalizedPath type throughout the build-comparison harness and display_slash for portable cache signatures.
@coderabbitai

coderabbitai Bot commented Jul 25, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@zackees, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 34 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: dfb2a479-f2a8-4637-b0de-6792642a2375

📥 Commits

Reviewing files that changed from the base of the PR and between c3b50db and a5919d9.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • bench/fastled-examples/Cargo.toml
  • bench/fastled-examples/src/build_comparison.rs
  • bench/fastled-examples/src/build_comparison_tests.rs
  • crates/fbuild-build-esp/src/esp32/orchestrator/framework_library_cache.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/issue-1155-dylint-workspace

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@zackees
zackees merged commit becc05e into main Jul 25, 2026
95 of 97 checks passed
@fastled-project-sync fastled-project-sync Bot moved this to Triage in FastLED Tracker Jul 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Triage

Development

Successfully merging this pull request may close these issues.

1 participant