fix(test): follow the soldr pin #1416 moved to 0.9.12 - #1419
Merged
Conversation
`native_release_workflow_uses_current_cross_toolchains` asserts the exact soldr version `template_native_build.yml` pins. #1416 (e4a871a) moved that pin 0.9.6 -> 0.9.12 for the pkg-config sysroot fix, but left the test's expected value at 0.9.6, so `Check` has been red on main ever since: assertion `left == right` failed: the setup-soldr step needs soldr >= 0.9.5 for catalogue-v2 Apple SDK assets left: Some("0.9.12") right: Some("0.9.6") That blocks every open PR, not just the branch that noticed it. Follow the pin, and extend the message to name the second floor as well -- it previously cited only the 0.9.5 catalogue-v2 requirement, which no longer explains why the pin sits where it does. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MLhWkMfzLjrnLTDMBE6Fj9
|
Warning Review limit reachedNext included review available in 39 minutes. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zackees
added a commit
that referenced
this pull request
Sep 6, 2026
Ships the SAMD core fix from #1418 (closes #1400). `samd-core` was fetched from GitHub's auto-generated source archive, which omits submodules by design. Tag 1.7.16 declares two under `libraries/`: `Adafruit_TinyUSB_Arduino` and `Adafruit_ZeroDMA`. That was latent until #1401 added the unpack-time submodule check, which fires on the package rather than on use -- so every SAMD build began failing before a compiler ran, taking out metro_m4, samd21, samd21_zero, samd51j and samd51p downstream in FastLED as soon as it pinned 2.5.22. The core now comes from Adafruit's board-index bundle, which does carry the submodule contents (368 files under Adafruit_TinyUSB_Arduino/ including tusb.h, 25 under Adafruit_ZeroDMA/), with its SHA-256 pinned and verified -- the old URL passed no checksum at all. Verified end to end: `fbuild build tests/platform/samd21 -e samd21` succeeds (flash 11420 bytes, ram 3828 bytes). Also carries #1419, which follows the soldr pin #1416 moved to 0.9.12 and had left `Check` red on main. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MLhWkMfzLjrnLTDMBE6Fj9
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The break
native_release_workflow_uses_current_cross_toolchainsasserts the exact soldr version thattemplate_native_build.ymlpins. #1416 (e4a871a) moved that pin0.9.6→0.9.12for the pkg-config sysroot fix but left the test's expected value at0.9.6, soCheck (ubuntu-latest)has been red onmainever since:This blocks every open PR, not just the branch that surfaced it (#1418).
The fix
Follow the pin. Also extend the assertion message to name the second floor — it previously cited only the 0.9.5 catalogue-v2 requirement, which no longer explains why the pin sits where it does.
I kept the exact-equality check rather than loosening it to a
>=comparison: pinning exactly is what makes an unreviewed bump show up as a failing test, which is the test's purpose. The cost is this one-line follow-up per deliberate bump.Verification
bash test -p fbuild-python -- native_release_workflow— 1 passed, 0 failed.🤖 Generated with Claude Code
https://claude.ai/code/session_01MLhWkMfzLjrnLTDMBE6Fj9