Skip to content

fix(test): relax dev_mode_port assertion to match function contract (closes #88)#98

Merged
zackees merged 1 commit intomainfrom
fix/88-dev-mode-port-assertion
Apr 18, 2026
Merged

fix(test): relax dev_mode_port assertion to match function contract (closes #88)#98
zackees merged 1 commit intomainfrom
fix/88-dev-mode-port-assertion

Conversation

@zackees
Copy link
Copy Markdown
Member

@zackees zackees commented Apr 18, 2026

Summary

get_daemon_port() documents a four-priority chain (env var → current-mode port file → other-mode port file → mode-default). The test asserted only outcome (4), so any legitimately present port file on disk (e.g., from a past daemon run that wrote 18900 before crashing) breaks the test. Relax the assertion to port > 0 — the actual contract the function promises.

Encountered during the session that produced #91; observed with a real 18900 port file that triggered assertion failed: port == 8765 || port == 8865.

Test plan

  • uv run cargo test -p fbuild-paths --lib dev_mode_port — passes.
  • Passes equally with a stale port file on disk or none.

…aults (closes #88)

get_daemon_port() documents a four-priority chain: env var, current-mode
port file, other-mode port file, mode-default. The test hardcoded the
mode-default (8765 or 8865) but a stale port file on disk legitimately
returns any u16, causing the test to panic. Relax the assertion to match
the function's actual contract (port > 0).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented Apr 18, 2026

Warning

Rate limit exceeded

@zackees has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 0 minutes and 29 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 29 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 096d0048-e9f9-4b25-ae7a-58081178875f

📥 Commits

Reviewing files that changed from the base of the PR and between 945bb74 and 208e12e.

📒 Files selected for processing (1)
  • crates/fbuild-paths/src/lib.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/88-dev-mode-port-assertion

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@zackees zackees merged commit 06af0cd into main Apr 18, 2026
75 of 77 checks passed
@zackees zackees deleted the fix/88-dev-mode-port-assertion branch April 18, 2026 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant