Conversation
…aults (closes #88) get_daemon_port() documents a four-priority chain: env var, current-mode port file, other-mode port file, mode-default. The test hardcoded the mode-default (8765 or 8865) but a stale port file on disk legitimately returns any u16, causing the test to panic. Relax the assertion to match the function's actual contract (port > 0). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning Rate limit exceeded
Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 0 minutes and 29 seconds. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
get_daemon_port()documents a four-priority chain (env var → current-mode port file → other-mode port file → mode-default). The test asserted only outcome (4), so any legitimately present port file on disk (e.g., from a past daemon run that wrote18900before crashing) breaks the test. Relax the assertion toport > 0— the actual contract the function promises.Encountered during the session that produced #91; observed with a real
18900port file that triggeredassertion failed: port == 8765 || port == 8865.Test plan
uv run cargo test -p fbuild-paths --lib dev_mode_port— passes.