Skip to content

fix(test): relax dev_mode_port assertion to match function contract (closes #88) #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zackees merged 1 commit into from
Apr 18, 2026
Merged

fix(test): relax dev_mode_port assertion to match function contract (closes #88) #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions crates/fbuild-paths/src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,10 +224,12 @@ mod tests {

#[test]
fn dev_mode_port() {
// Note: can't set env vars in parallel tests safely,
// so just test the function exists and returns a valid port
// Note: can't set env vars in parallel tests safely, and the
// function's own priority chain (env var > current-mode port file >
// other-mode port file > mode-default) legitimately returns any
// u16 > 0. Assert only the contract the function actually promises.
let port = get_daemon_port();
assert!(port == 8765 || port == 8865);
assert!(port > 0);
}

#[test]
Expand Down
Loading