Skip to content

Conversation

@zhenlin
Copy link
Contributor

@zhenlin zhenlin commented Feb 24, 2025

To address #4920, changed BeanDeserializerFactory.addBeanProps to check creator properties when a ValueInstantiator is available.

…ies when a ValueInstantiator is available. This addresses FasterXML#4920.
@cowtowncoder
Copy link
Member

Ok, fix makes sense, I think, and looks good overall. Thank you!

Just two things... first, although I can merge it for 2.19 as submitted, it might make more sense to create PR against 2.18 branch instead, so it could be included in 2.18.3 patch.

Second: before I merge pr (regardless of target branch), I'd need CLA (just needs to be done once before the first pr merged). It's from here:

https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf

and is usually easiest to do by printing, filling & signing, scanning/photo, emailing to cla at fasterxml dot com.

Once this is done I can proceed with merging.

Thank you again for submitting this, looking forward to merging.

@zhenlin zhenlin mentioned this pull request Feb 25, 2025
@zhenlin
Copy link
Contributor Author

zhenlin commented Feb 25, 2025

Thanks. I have opened #4984 to backport this to 2.18. Please let me know if there is anything else I can help with to get this fix released.

@cowtowncoder
Copy link
Member

@zhenlin See my note on CLA, that's the main thing.

On branch: going forward one pr is fine, starting with the oldest target: then we just merge forward.

@zhenlin
Copy link
Contributor Author

zhenlin commented Feb 25, 2025

Sure. I sent the signed CLA earlier.

@cowtowncoder
Copy link
Member

@zhenlin wow, that was quick! Did not realize, saw it now.

@cowtowncoder
Copy link
Member

Closing in favor of #4984 (will merge forward)

@zhenlin zhenlin deleted the fix-4920 branch February 25, 2025 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants