-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Change BeanDeserializerFactory.addBeanProps to check creator properties #4982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…ies when a ValueInstantiator is available. This addresses FasterXML#4920.
|
Ok, fix makes sense, I think, and looks good overall. Thank you! Just two things... first, although I can merge it for 2.19 as submitted, it might make more sense to create PR against 2.18 branch instead, so it could be included in 2.18.3 patch. Second: before I merge pr (regardless of target branch), I'd need CLA (just needs to be done once before the first pr merged). It's from here: https://github.com/FasterXML/jackson/blob/master/contributor-agreement.pdf and is usually easiest to do by printing, filling & signing, scanning/photo, emailing to Once this is done I can proceed with merging. Thank you again for submitting this, looking forward to merging. |
src/test/java/com/fasterxml/jackson/databind/deser/BeanDeserializerFactory4920Test.java
Outdated
Show resolved
Hide resolved
src/test/java/com/fasterxml/jackson/databind/deser/BeanDeserializerFactory4920Test.java
Show resolved
Hide resolved
|
Thanks. I have opened #4984 to backport this to 2.18. Please let me know if there is anything else I can help with to get this fix released. |
|
@zhenlin See my note on CLA, that's the main thing. On branch: going forward one pr is fine, starting with the oldest target: then we just merge forward. |
|
Sure. I sent the signed CLA earlier. |
|
@zhenlin wow, that was quick! Did not realize, saw it now. |
|
Closing in favor of #4984 (will merge forward) |
To address #4920, changed
BeanDeserializerFactory.addBeanPropsto check creator properties when aValueInstantiatoris available.