Fix #4603 (Keep stacktrace when re-throwing exception with JsonMappingException)

[JooHyukKim]

Fixes #4603

[cowtowncoder]

Since this is for 3.0, I think we can default it to false.

Going further down this route: do we even need a MapperFeature? I am ok with unwrapping being removed for this specific case (of setter/getter/field access).

@stevenschlansker WDYT?

[stevenschlansker]

I personally don't see the value of having this configurable in the first place - for me, I would always be OK with nested exceptions where Jackson adds helpful descriptions like JacksonMappingException: couldn't write field 'foo' from type 'bar' but always preserves the cause caused by: IllegalAccessError: your module doesn't read the other module or whatever it is.

I would always keep the ultimate cause myself, even if it is not "friendly". But I can understand how other people might have different expectations, like Spring Boot will try to hide the failure details from you behind some friendly message - but I hate it ;)

[cowtowncoder]

Thanks @stevenschlansker. I'll need to think about this a bit... I am not married to the unwrapping feature even tho I originally added it in the first place.

[JooHyukKim]

+1 on having preserving the ultimaite root cause. Seems like there is no harm in it?

[cowtowncoder]

Question: are we happy with the name? For now this specifically applies to setter/getter/field access handling, and we could try to make it more specific.
(naming only matters if we decide to keep configurability, of course)

[JooHyukKim]

Hmmm, I was thinking since MapperFeature being global, would apply to wherever we can.
So yes, name being generic is okay.

[cowtowncoder]

@JooHyukKim I think we should change default to false and then I can review and probably merge this.

EDIT: Actually.... let's make things even simpler and simply remove wrapping without new MapperFeature.

[JooHyukKim]

EDIT: Actually.... let's make things even simpler and simply remove wrapping without new MapperFeature.

Sorry late reply. Will do!