Fix #4629 @JsonIncludeProperties & @JsonIgnoreProperties is ignored when deserializing Records

[JacksonJang]

resolves #4629

I moved the IgnorePropertiesUtil.shouldIgnore() check to the top of the loop, before the creatorProp check.
This ensures that ignored properties are skipped correctly before any creator property processing happens.

[cowtowncoder]

@JacksonJang Looks good, thank you for contributing this!

One thing we need before I can merge the fix is we need CLA from:

https://github.com/FasterXML/jackson/blob/main/contributor-agreement.pdf

it only needs to be sent once, before the first contribution and is valid for all future Jackson contributions.
The usual way is to print it, fill & sign, scan/photo, email to cla at fasterxml dot com.
Once I have it, I can merge this in 3.x (for inclusion in 3.1.0).

[cowtowncoder]

LGTM, just need CLA

[JacksonJang]

I sent an email to cla@fasterxml.com after reading your message
Thank you!

Have a good day :)

[cowtowncoder]

CLA received, can proceed.

[cowtowncoder]

Hmmmh. I think this fix broke this Kotlin test:

FasterXML/jackson-module-kotlin#308

which is unfortunate...

[JacksonJang]

Is there any test case where that behavior occurs?
I’ll review it again on my side.

[cowtowncoder]

Just the Kotlin test:

https://github.com/FasterXML/jackson-module-kotlin/blob/3.x/src/test/kotlin/tools/jackson/module/kotlin/test/github/Github308.kt

which may be tricky to convert into Java one....

(this is why I didn't catch it before merging -- we have cascading build across modules but only after merging)

[JacksonJang]

Thank you for the answer :)
Would you mind taking a look with the changes I pushed?

The change I made specifically resolves the conflict between a creator property and an ignored property name.

[JacksonJang]

I manually built the jackson-databind library and placed it into the .m2 folder to test it, and everything worked correctly.
I believe it should be safe to merge.