Strings containing double quotes prevent parsing

[ddanielou]

Feeding that kind of input data to Hell2Shape::generate():

$array = [
    'testStringWithDoubleQuotes' => 'askjdashd"askjdasjkd',
];

$result = Hell2Shape::generate($array, GeneratorConfig::withoutDocComment());

… triggers this exception:

Fatal error: Uncaught Feolius\Hell2Shape\Lexer\LexerException: Unable to define token at line 7 and column 25: 
askjdasjkd"
}
... in /var/www/html/vendor/feolius/hell2shape/src/Lexer/Lexer.php:88

[Feolius]

Hotfix pushed in 0.4.4. It just expects double quote followed by new line character. But it is not a 100% solution. Because strings containing double quotes and new lines still trigger an error.

Consider the following example

$a = [
    'k1' => 'v1"
  ["k2"]=>
  string(1) "v2',
];
$b = ['k1' => 'v1', 'k2' => 'v2'];
var_dump($a);
var_dump($b);

The output will be

array(1) {
  ["k1"]=>
  string(30) "v1"
  ["k2"]=>
  string(1) "v2"
}
array(2) {
  ["k1"]=>
  string(2) "v1"
  ["k2"]=>
  string(2) "v2"
}

so, the only difference is string(30) vs string(2). That's why it may require preprocessor for correct handling such scenarios.

[ddanielou]

Yeah, I didn't know to handle this properly, which is why I didn't submit a PR. The thing is, var_dump() may be the wrong function to use. Its result is made for humans, so trying to parse it may be a dead end.

Is there a reason why you don't use var_export() instead?
Edit: nope, I'm completely wrong. var_export() doesn't contain type information.

[Feolius]

yes. var_dump was chosen just because it is universal. It is not perfect:(

At this point, I believe hotfix solves 90% cases with double quotes. As for the double quotes followed by new line, I think it is still feasible to handle that. Just need more work. Postpone it for now. Will fix little a bit later when have more spare time.