Skip to content

fix(action): skip compare+comment when comment-on-pr is false#96

Merged
BryanFRD merged 2 commits intomainfrom
fix/skip-compare-when-comment-off
Apr 22, 2026
Merged

fix(action): skip compare+comment when comment-on-pr is false#96
BryanFRD merged 2 commits intomainfrom
fix/skip-compare-when-comment-off

Conversation

@BryanFRD
Copy link
Copy Markdown
Contributor

Matrix callers set comment-on-pr: false and do the comparison in an aggregate job. The inline compare step was still running and failing on regression alerts (no PR-review permission on matrixed jobs). Gate it on inputs.comment-on-pr == 'true'.

@BryanFRD BryanFRD merged commit e75df33 into main Apr 22, 2026
3 checks passed
@BryanFRD BryanFRD deleted the fix/skip-compare-when-comment-off branch April 22, 2026 14:28
BryanFRD added a commit that referenced this pull request Apr 22, 2026
* fix(action): pass criterion group-filter as positional arg

* fix(action): skip compare+comment step when comment-on-pr is false
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant