Skip to content

fix(action): skip compare+comment when comment-on-pr is false #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BryanFRD merged 2 commits into from
Apr 22, 2026
+9 −2
Merged

fix(action): skip compare+comment when comment-on-pr is false #96

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
039ba97
fix(action): pass criterion group-filter as positional arg
BryanFRD Apr 22, 2026
8857eaa
fix(action): skip compare+comment step when comment-on-pr is false
BryanFRD Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,8 @@ runs:
GROUP_FILTER="${{ inputs.group-filter }}"
BENCH_ARGS=(--bench ferrflow_benchmarks -- --output-format bencher)
if [ -n "$GROUP_FILTER" ]; then
BENCH_ARGS+=(--filter "$GROUP_FILTER")
# criterion takes the filter as a positional arg, not --filter
BENCH_ARGS+=("$GROUP_FILTER")
fi
cargo bench "${BENCH_ARGS[@]}" 2> bench-stderr.log | tee raw-output.txt
bench_exit=${PIPESTATUS[0]}
Expand Down Expand Up @@ -141,7 +142,13 @@ runs:
fi

- name: Compare and comment (PR)
if: (inputs.type == 'micro' || inputs.type == 'all') && github.event_name == 'pull_request'
# Skip the compare+comment step entirely when the caller disables PR
# commenting (matrix shards set comment-on-pr: false — an aggregate job
# merges all shard outputs and runs the comparison once with proper
# pull-requests: write permission). Keeping this step here would fail
# on regression alerts because matrixed jobs don't have permission to
# post PR reviews.
if: (inputs.type == 'micro' || inputs.type == 'all') && github.event_name == 'pull_request' && inputs.comment-on-pr == 'true'
uses: benchmark-action/github-action-benchmark@v1
with:
tool: cargo
Expand Down
Loading