feat(site): declare the site as English-only - #144
Merged
Conversation
BryanFRD
enabled auto-merge (squash)
August 18, 2026 08:48
![ferrfleet[bot]](https://avatars.githubusercontent.com/in/4354888?s=60&v=4){kind=small}
There was a problem hiding this comment.
Small, well-scoped change: bumps @ferrlabs/ui-ng to 1.23.0 (lockfile + package.json in sync) and sets locales: ['en'] in the site chrome config to drop the EN/FR switcher and hreflang alternates pointing at an unbuilt /fr/. Verified build/typecheck claims in the description are plausible given the diff's scope. Nothing blocking.
SonarQube — aucune nouvelle issueComparaison entre le projet bac à sable de cette PR et la branche par défaut : SonarQube Community n'analyse pas les PR, ce delta est calculé côté CI. Détail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ferrlabs/ui-ng@1.23.0(pulled in by #142) carries thelocalesoption added in UI#401, so the site can finally say it ships one language.Without it the navbar rendered an EN/FR switcher and the shell emitted
hreflangalternates, both pointing at a/fr/that was never built. The alternate was the worse half: a visible link a reader might not click is one thing, anhreflangis a promise a crawler follows.Verified:
pnpm typecheckclean,pnpm buildproduces the same 25 pages, and the prerendered HTML now carries nohreflangat all.This was the last thing holding the site back from deployment.
It is also, deliberately, the commit that cuts the site's first release. Nothing had triggered one since the versioning split: every commit on main since v0.39.0 has been
ci:,chore:or adocs:touching server files, none of which bump anything. So the site image had never been built — not because the build was broken, but because it had never been asked to run. With #143 merged,site@2026.8.18should now route toBuild & Push Siteand landghcr.io/ferrlabs/lfsx/site.