fix(ci): keep the server publish workflows off site releases - #145
Merged
Conversation
BryanFRD
enabled auto-merge (squash)
August 18, 2026 08:54
There was a problem hiding this comment.
Guard mirrors the existing chart.yml pattern exactly. Verified binaries.yml: verify and npm both declare needs: build, so skipping build on a non-v tag correctly skips them too — no separate guard needed there. publish.yml has a single job, guarded directly. Looks correct.
SonarQube — aucune nouvelle issueComparaison entre le projet bac à sable de cette PR et la branche par défaut : SonarQube Community n'analyse pas les PR, ce delta est calculé côté CI. Détail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first site release,
site@2026.8.18, fired every release-triggered workflow in the repository.Dockerrouted correctly (site image built, server image skipped — #143 did its job), andChartskipped itself because it already guards on avtag.PublishandBinariesdid neither: both ran against server artefacts under a site tag and failed.They failed rather than published the wrong thing, which is luck rather than design —
publish.ymlchecks outgithub.event.release.tag_nameand goes straight at crates.io and npm, and those are publications that cannot be taken back.Both now carry the same guard
chart.ymlalready had:binaries.ymlonly needs it onbuild:verifyandnpmdeclareneeds: build, so a skipped build skips them too.publish.ymlhas a single job.This is the same class of bug as #143 and I should have swept for it there instead of fixing only the workflow I happened to be looking at. Every
on: releaseworkflow in a repository that now releases two things under two tag shapes needed checking, and I checked one.