Skip to content

perf: improve application GPU performance - #118

Merged
ChugunovRoman merged 3 commits into
Figma-Linux:masterfrom
devhammed:patch-1
Aug 6, 2020
Merged

perf: improve application GPU performance#118
ChugunovRoman merged 3 commits into
Figma-Linux:masterfrom
devhammed:patch-1

Conversation

@devhammed

@devhammed devhammed commented Aug 5, 2020

Copy link
Copy Markdown
Contributor

The application currently lags and this pull request will boost the performance...I applied the command line options discussed in #90

Before:

Screenshot from 2020-08-05 10-15-25

After:

Screenshot from 2020-08-05 10-13-24

@ChugunovRoman
ChugunovRoman merged commit d82891f into Figma-Linux:master Aug 6, 2020
@devhammed
devhammed deleted the patch-1 branch August 6, 2020 09:54
@GitSquared

Copy link
Copy Markdown
Contributor

@ChugunovRoman Would you consider moving the switches from this PR from the .desktop files to appendSwitch calls directly in the app's code?

I'm having trouble with GPU acceleration not being enabled with the app installed through the AUR even though the switches are present:

image

There's already a section in App.ts where switches are appended, for colorspace setup:

const colorSpace = storage.get().app.enableColorSpaceSrgb;
if (colorSpace) {
E.app.commandLine.appendSwitch("force-color-profile", "srgb");
} else {
E.app.commandLine.appendSwitch("disable-color-correct-rendering");
}

I added appendSwitch calls before the colorspace logic on a local fork and it successfully enabled WebGL hardware acceleration where CLI switches wouldn't.

I can make a PR if you're fine with it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants