feat: add sp blocklist to skip checks for specific providers#452
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a global Storage Provider (SP) blocklist feature so scheduled automation can skip running checks against specific providers, addressing issue #364.
Changes:
- Introduces
BLOCKED_SP_IDSandBLOCKED_SP_ADDRESSESenv vars and plumbs them into backend config asspBlocklists. - Applies blocklist filtering to scheduled jobs (deal, retrieval, data_set_creation) and data-retention polling.
- Adds unit tests for the blocklist helper and for job/data-retention behavior under blocking.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| docs/environment-variables.md | Documents new SP blocklist env vars and behavior scope (scheduled-only). |
| apps/backend/src/config/app.config.ts | Adds env vars + parsing into spBlocklists config structure. |
| apps/backend/src/common/sp-blocklist.ts | Adds isSpBlocked() helper used across schedulers/services. |
| apps/backend/src/common/sp-blocklist.spec.ts | Unit tests for isSpBlocked() behavior. |
| apps/backend/src/jobs/jobs.service.ts | Skips scheduling and runtime execution for blocked providers; updates tested-provider gauge logic. |
| apps/backend/src/jobs/jobs.service.spec.ts | Adds tests for schedule skipping, runtime skipping, and gauge behavior with global blocklists. |
| apps/backend/src/data-retention/data-retention.service.ts | Filters blocked providers out of data-retention polling inputs. |
| apps/backend/src/data-retention/data-retention.service.spec.ts | Adds tests ensuring blocked providers are excluded from polling. |
| apps/backend/.env.example | Adds commented examples for the new blocklist env vars. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #364