Skip to content

feat: add sp blocklist to skip checks for specific providers#452

Merged
silent-cipher merged 4 commits into
mainfrom
feat/enable-disable-sp
Apr 17, 2026
Merged

feat: add sp blocklist to skip checks for specific providers#452
silent-cipher merged 4 commits into
mainfrom
feat/enable-disable-sp

Conversation

@silent-cipher
Copy link
Copy Markdown
Collaborator

Closes #364

Copilot AI review requested due to automatic review settings April 15, 2026 15:10
@FilOzzy FilOzzy added this to FOC Apr 15, 2026
@github-project-automation github-project-automation Bot moved this to 📌 Triage in FOC Apr 15, 2026
@rjan90 rjan90 moved this from 📌 Triage to 🔎 Awaiting review in FOC Apr 15, 2026
@rjan90 rjan90 requested review from SgtPooki and removed request for Copilot April 15, 2026 15:12
@rjan90 rjan90 added this to the M4.2: mainnet GA milestone Apr 15, 2026
@silent-cipher silent-cipher requested a review from Copilot April 15, 2026 15:14
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a global Storage Provider (SP) blocklist feature so scheduled automation can skip running checks against specific providers, addressing issue #364.

Changes:

  • Introduces BLOCKED_SP_IDS and BLOCKED_SP_ADDRESSES env vars and plumbs them into backend config as spBlocklists.
  • Applies blocklist filtering to scheduled jobs (deal, retrieval, data_set_creation) and data-retention polling.
  • Adds unit tests for the blocklist helper and for job/data-retention behavior under blocking.

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
docs/environment-variables.md Documents new SP blocklist env vars and behavior scope (scheduled-only).
apps/backend/src/config/app.config.ts Adds env vars + parsing into spBlocklists config structure.
apps/backend/src/common/sp-blocklist.ts Adds isSpBlocked() helper used across schedulers/services.
apps/backend/src/common/sp-blocklist.spec.ts Unit tests for isSpBlocked() behavior.
apps/backend/src/jobs/jobs.service.ts Skips scheduling and runtime execution for blocked providers; updates tested-provider gauge logic.
apps/backend/src/jobs/jobs.service.spec.ts Adds tests for schedule skipping, runtime skipping, and gauge behavior with global blocklists.
apps/backend/src/data-retention/data-retention.service.ts Filters blocked providers out of data-retention polling inputs.
apps/backend/src/data-retention/data-retention.service.spec.ts Adds tests ensuring blocked providers are excluded from polling.
apps/backend/.env.example Adds commented examples for the new blocklist env vars.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread apps/backend/src/common/sp-blocklist.ts Outdated
Comment thread apps/backend/src/jobs/jobs.service.ts
Copy link
Copy Markdown
Collaborator

@SgtPooki SgtPooki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in general lgtm, i opened a small pr on top: #455

@github-project-automation github-project-automation Bot moved this from 🔎 Awaiting review to ✔️ Approved by reviewer in FOC Apr 16, 2026
@silent-cipher silent-cipher merged commit 2c43d4d into main Apr 17, 2026
7 checks passed
@silent-cipher silent-cipher deleted the feat/enable-disable-sp branch April 17, 2026 19:21
@github-project-automation github-project-automation Bot moved this from ✔️ Approved by reviewer to 🎉 Done in FOC Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🎉 Done

Development

Successfully merging this pull request may close these issues.

dealbot should be able to enable/disable testing against specific SPs

5 participants