fix: skip address-blocked jobs before context resolution#455
Merged
silent-cipher merged 1 commit intoApr 17, 2026
Merged
Conversation
SgtPooki
force-pushed
the
codex/pr452-blocklist-runtime-guard
branch
from
b1a5b7a to
2622d9f
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Centralizes runtime SP blocklist handling in JobsService so address-blocked providers are skipped before resolving provider metadata (wallet/DB), and adds regression coverage to prevent reintroducing provider-context lookups for address-blocked queued jobs.
Changes:
- Added a shared
resolveRunnableProviderJobContexthelper to apply address-based blocking pre-context and ID-based blocking post-context. - Updated deal/retrieval/data-set-creation job handlers to use the shared helper instead of inline blocklist checks.
- Added a regression test ensuring address-blocked jobs don’t attempt provider context resolution (wallet/DB).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| apps/backend/src/jobs/jobs.service.ts | Introduces centralized runtime blocklist/context gating and wires it into SP job handlers. |
| apps/backend/src/jobs/jobs.service.spec.ts | Adds regression coverage for address-blocked jobs with missing provider context. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
silent-cipher
approved these changes
Apr 16, 2026
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FOC
silent-cipher
merged commit 0faee7e
into
FilOzone:feat/enable-disable-sp
12 checks passed
silent-cipher
added a commit
that referenced
this pull request
Apr 17, 2026
* feat: add sp blocklist to skip checks for providers * chore: address pr comments * fix: skip address-blocked jobs before context resolution (#455) * chore: address copilot review comments --------- Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
PR is on top of #452