docs(checks): resolve cid.contact verification design from PR review#581
Merged
silent-cipher merged 6 commits intoMay 29, 2026
Merged
Conversation
Document cidContactVerification metric, separate cid.contact sub-status, and ipniVerifyMs timer semantics for the two-stage indexer checks. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
BigLep
commented
May 29, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Dealbot check documentation to reflect the revised two-stage IPNI verification design (filecoinpin.contact driving discoverability, with a separate cid.contact verification lifecycle and updated metric semantics).
Changes:
- Refines
ipniVerificationComplete/ipniVerifyMsdocumentation to describe sequential indexer verification and updated timer semantics. - Reworks the “count related metrics” section and introduces
cidContactVerificationas a separate outcome fromdiscoverabilityStatus. - Updates Data Storage check docs to explain the rationale and lifecycle timing of the cid.contact cross-check.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
| docs/checks/events-and-metrics.md | Updates event/metric definitions and restructures the status/count metrics documentation for the two-stage IPNI design. |
| docs/checks/data-storage.md | Updates Data Storage verification flow docs and adds cid.contact verification lifecycle/status documentation. |
Clarify ipniVerifyMs labels, cidContactVerification skipped emission, timer anchors on ipniVerificationStart, and source citations. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
Incorporated some of the review feedback in 335cf91:
Still open for further review — did not take every Copilot suggestion (e.g. full rewrite of the count-metrics section intro). |
Collaborator
|
I've split the changes here into one another pr #583 . It has general metrics docs structure and clarity updates. Here, I've removed |
silent-cipher
approved these changes
May 29, 2026
github-project-automation
Bot
moved this from 📌 Triage
to ✔️ Approved by reviewer
in FOC
silent-cipher
added a commit
that referenced
this pull request
Jun 2, 2026
…ck (#580) * docs: initial cid.contact ipni check design * docs(checks): resolve cid.contact verification design from PR review (#581) * docs(checks): resolve cid.contact verification design from PR review Document cidContactVerification metric, separate cid.contact sub-status, and ipniVerifyMs timer semantics for the two-stage indexer checks. Co-authored-by: Cursor <cursoragent@cursor.com> * docs(checks): link pullCheckStatus values to pull-check spec Co-authored-by: Cursor <cursoragent@cursor.com> * docs(checks): address PR review on cid.contact metrics docs Clarify ipniVerifyMs labels, cidContactVerification skipped emission, timer anchors on ipniVerificationStart, and source citations. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: split #581 * moved to another pr * docs: remove pending cidContactVerification state --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: silent-cipher <puspendramahariya@gmail.com> * feat(ipni): add cid.contact verification * chore: address copilot comments * chore: address pr comment --------- Co-authored-by: Steve Loeppky <biglep@filoz.org> Co-authored-by: Cursor <cursoragent@cursor.com>
silent-cipher
added a commit
that referenced
this pull request
Jun 3, 2026
* docs: initial cid.contact ipni check design * docs(checks): resolve cid.contact verification design from PR review Document cidContactVerification metric, separate cid.contact sub-status, and ipniVerifyMs timer semantics for the two-stage indexer checks. Co-authored-by: Cursor <cursoragent@cursor.com> * docs(checks): link pullCheckStatus values to pull-check spec Co-authored-by: Cursor <cursoragent@cursor.com> * docs(checks): address PR review on cid.contact metrics docs Clarify ipniVerifyMs labels, cidContactVerification skipped emission, timer anchors on ipniVerificationStart, and source citations. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: split #581 * docs: improve metrics docs structure and clarity * moved to another pr * docs: remove pending cidContactVerification state * docs(checks): resolve cid.contact verification design from PR review (#581) * docs(checks): resolve cid.contact verification design from PR review Document cidContactVerification metric, separate cid.contact sub-status, and ipniVerifyMs timer semantics for the two-stage indexer checks. Co-authored-by: Cursor <cursoragent@cursor.com> * docs(checks): link pullCheckStatus values to pull-check spec Co-authored-by: Cursor <cursoragent@cursor.com> * docs(checks): address PR review on cid.contact metrics docs Clarify ipniVerifyMs labels, cidContactVerification skipped emission, timer anchors on ipniVerificationStart, and source citations. Co-authored-by: Cursor <cursoragent@cursor.com> * docs: split #581 * moved to another pr * docs: remove pending cidContactVerification state --------- Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: silent-cipher <puspendramahariya@gmail.com> * feat(ipni): add cid.contact verification * chore: address copilot comments * chore: address pr comment * chore: address pr comment --------- Co-authored-by: Steve Loeppky <stvn@loeppky.com> Co-authored-by: Cursor <cursoragent@cursor.com> Co-authored-by: Steve Loeppky <biglep@filoz.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up documentation for PR #580 addressing review feedback on the two-stage IPNI verification design:
discoverabilityStatusremains driven only by filecoinpin.contactcidContactVerificationreplacescidContactStatuswith sub-status-aligned values (success,failure.*,skipped)ipniVerifyMstimer semantics: filecoinpin.contact usesadvertisedAt; cid.contact measures incremental propagation from filecoinpin.contact completionTest plan
#cidContactVerification, FAQ) resolvefeat/check-cid-contactbefore feat: add cid.contact ipni verification after filecoinpin.contact check #580 lands onmainMade with Cursor