docs: improve metrics docs structure and clarity

[silent-cipher]

Major changes

• docs/checks/data-storage.md

  • Removed the Implemented? column from the assertions table — all assertions are implemented, so the column added noise without value.
  • Replaced the bare source links to types.ts at the bottom of the status section with a richer prose explanation clarifying that Prometheus outcome strings come from heck-metrics.service.ts / classifyFailureStatus, and that DealStatus/IpniStatus are coarser
    implementation-level states, not the dashboard value labels.

• docs/checks/events-and-metrics.md

  • Renamed "Status Count Related Metrics" → "Count Related Metrics" (more accurate since it includes non-status counts).
  • Fixed a typo: "additonal" → "additional".
  • Added an explanatory note clarifying that the value label is confusingly named (should have been called status) and how this manifests in ClickHouse queries (label('value') and value_avg).
  • Added a Counter Value and Additional Info column to the count metrics table, making the semantics of each counter explicit (most emit 1, with dataSetChallengeStatus being the notable exception: it emits period_delta × 5).
  • Split pdp_provider_estimated_overdue_periods out of the count metrics table into a new "Other Gauges" section, since it's a gauge (level measurement), not a counter — it doesn't use the value outcome label.

Changes from #581

[Copilot]

Pull request overview

Docs-only PR that restructures and clarifies the metrics documentation for the dealbot checks. It removes a redundant column, adds explicit columns/notes for counter semantics, fixes a typo, and replaces raw type-source links with a prose explanation of where Prometheus outcome strings come from versus internal entity states.

Changes:

• events-and-metrics.md: rename "Status Count Related Metrics" → "Count Related Metrics", fix "additonal" typo, add a note about the confusing value label, add Additional Info and Counter Value columns, and split pdp_provider_estimated_overdue_periods into a new "Other Gauges" section.
• data-storage.md: drop the always-"Yes" Implemented? column from the assertions table, and replace the bare types.ts source links with a prose explanation distinguishing Prometheus outcome strings (from check-metrics.service.ts / classifyFailureStatus) from coarser DealStatus/IpniStatus entity states.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
docs/checks/events-and-metrics.md	Restructures count metrics table, adds value-label note, and splits gauge out into its own section.
docs/checks/data-storage.md	Removes the Implemented? column and rewrites the status-sources prose.

[rjan90]

@silent-cipher anything blocking merging this?

[silent-cipher]

This is built on top of #580 . So, thought It would be better to merge it once #580 is approved.