design: move Music and Books from About into Stack - #132
Conversation
Both sit oddly in an already-crowded About panel; Stack's own framing
("tools, technology and apps I use every day") covers them more
naturally -- Spotify is an app used daily, and a reading list reads as
a natural addendum to a personal stack. Drops the About paragraph that
existed solely to link out to them, folds a short mention into Stack's
description instead.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
|
Warning Review limit reachedNext included review available in 1 minute. View limit detailsLimit details: You’ve used the included review currently available. You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. Review configuration: ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
under the Good morening/good evening section there is under stack make personal or smthg like that section to conatain music and reading list also in music and reading list there is mb-32 we want to remove |
Wraps Music and Books in a "Personal" sub-section under Stack (same pattern as "Open Source" under Projects) instead of dropping them in loose, so they read as a distinct group rather than more stack items. Uses the portfolio's usual horizontal border-line dividers between groups instead of margin. Removed the leftover mb-32 on AboutOverview, AboutMusic, and AboutBooks -- excessive now that these aren't meant to carry huge standalone section gaps. SectionHeading's title also drops from text-3xl to text-lg to match Stack's own typography scale instead of a page-level heading size.
|
All fixed:
|
1 participant
Closes #131
Summary
AboutMusic/AboutBooksmoved from theaboutPanel'sPanelContentinto thestackPanel'sPanelContent, after the tech-stack list.PanelDescriptioninstead.AboutMusic/AboutBooksthemselves (self-contained, own anchors/copy-links) or tostackItemCount(still counts onlySTACK_SECTIONS, matching how "Open Source" already sits inside Projects without being folded into that panel's own count).Test plan
pnpm lint— no new errorspnpm build— passes#playlists/#readingsnow render after#stackin document order (previously inside#about)